Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-order store menu items #406

Open
alanmels opened this issue Dec 21, 2022 · 5 comments · May be fixed by #428
Open

Re-order store menu items #406

alanmels opened this issue Dec 21, 2022 · 5 comments · May be fixed by #428

Comments

@alanmels
Copy link
Member

alanmels commented Dec 21, 2022

A minor issue that still would be good to fix. On Drupal 7 Ubercart's menu was ordered like this:

Screenshot 2022-12-20 at 10 28 35 PM

with the Configuration item placed in the very end. And it was really convenient since users would visit the configuration section frequently only during setting up and configuring their online stores. Which would be only fraction of time considering after that initial period, they usually concentrate their attention on other menu items on daily basis.

Now, the Configuration item is placed on the very top on Backrop:

Screenshot 2022-12-20 at 10 28 54 PM

Of course, one can always adjust the menu item order per their liking on /admin/structure/menu/manage/management, but still, if possible, consider changing the weights of the menu items so it comes with reverted to original order by default.

@laryn laryn changed the title Re-order Sotre menu items Re-order store menu items Dec 21, 2022
@laryn
Copy link
Member

laryn commented Dec 21, 2022

I'm interested in hearing conversation on this. Here's the original issue, which was mostly concerned with the stacking of the Ubercart dashboard page:

@bugfolder
Copy link
Collaborator

bugfolder commented Dec 22, 2022

I hardly ever use the dashboard page. For my use cases, though, having the Configuration menu at the bottom is best, because I (site builder) am the only one who uses that submenu, while my store manager uses all the other submenus; so it's better to have the store manager's admin pages all above Configuration. (Of course, it would be even more Backdroppy to put the Configuration pages at Admin > Configuration > Store > ..., but that's probably too big of a change to inflict on Ubercarters coming from D7.)

At any rate, it's easy enough for site builders to move the Configuration submenu up or down. But if D7 had it at the bottom (and checking my old D7 site, yeah, that's where it was), I'd favor moving it (back) to the bottom for maximum familiarity to D7 refugees.

bugfolder added a commit to bugfolder/ubercart that referenced this issue Jan 1, 2023
@bugfolder bugfolder linked a pull request Jan 1, 2023 that will close this issue
@bugfolder
Copy link
Collaborator

I've created a PR that moves it down in the menu by adjusting the weight.

A closely related issue is the position of the settings block (left or right) on the admin page at admin/store. This PR also changes some left/right settings to put the settings on the right and everything else on the left, which roughly balances the page, to look like this:

store_admin

Or at least, it should; but it doesn't currently, because the Seven theme ignores the documented behavior of left and right and makes its own choices about where to put blocks. I think this is wrong, and have created this core issue to address it:

backdrop/backdrop-issues#5903

I don't know how receptive the PtB will be about changing the behavior of Seven, given its ubiquity, so perhaps we should wait to see how that issue is received before deciding whether to go ahead with this PR.

@klonos
Copy link
Member

klonos commented Mar 11, 2023

Not sure if this was mentioned as an idea before, but instead of relying on the menu order and then reflecting that in the placement of these "blocks", how about if admin/store was actually converted into a "dashboard" with a 2-column layout? That way:

  • Ubercart could rearrange the menu items to what makes more sense (move the "configuration" item to be last by default, like the original report by @alanmels suggested)
  • People could still reorder menu items to what makes more sense for their situation (but that wouldn't affect the position of the blocks in the store admin page)
  • Each top-level menu item under the main parent "Store" could become "menu block" component, and these various store dashboard components could be independently placed also where is makes sense.

@bugfolder
Copy link
Collaborator

how about if admin/store was actually converted into a "dashboard" with a 2-column layout?

That sounds like a great approach. I'd been thinking of replacing the theme('admin_page',...) with something custom (but static); custom (but dashboard) sounds even better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants