update.php: Do not add language prefix to "Skip backup" and "Cancel" link

[indigoxela]

Description of the bug

This only affects multilingual sites, which have a language prefix set for the default language.

Steps To Reproduce

1. Enable the language and locale module
2. Configure the language to use a prefix - also the default language
3. Run an update
4. When coming to the "Pre-update backup" step, click "Skip backup"

Actual behavior

You end up with a 404.

The requested page "/en/core/update.php?op=selection&token=4_jjblabla..." could not be found.

Expected behavior

Getting to the next step.

Additional information

• Backdrop CMS version: 1.30.0 (or dev)

This happens, because url() adds the language prefix to the link.

The function chain for the skip link is:

theme_link() -> l() -> url()

And the url() function considers the language, but our default page to update can't handle that.

The quick workaround is to copy the link and strip the language prefix manually, to get to the next step. Doesn't seem ideal. 😉

BTW: the same is true for the "Cancel" link on the next page ("Review updates") - 404.

[indigoxela]

My suggestion would be to use a more low-level approach for creating links in update.php.
Similar to what we did in #5092

There's no need for aliases, no need for sanitizing, ... But maybe I'm missing something.

[indigoxela]

A PR is available for testing and review.

I don't think, it's possible to do testing only in the sandbox, as there needs to be a trigger for an update.

For local testing I'd recommend a custom module, where you uncomment the update hook after you installed it.

foobar.info:

name = Foobar
description = Test update stuff
type = module
backdrop = 1.x

foobar.install:

<?php

/**
 * Trigger update.
 */
//function foobar_update_1000() {}

^^ after intalling this module, uncomment the update hook and visit admin/reports/status.

[olafgrabienski]

Issue confirmed, nice catch!

I've tested locally with the Foobar module (needs also a .module file, btw), and the PR works for me. I've also checked if the Skip link continues to work on a multilingual site without prefix for the default language, which is the case.

[argiepiano]

Also reproduced, also confirmed the patch makes sense, code LGTM

[quicksketch]

Thank you @indigoxela, @olafgrabienski, and @argiepiano! I merged backdrop/backdrop#4999 into 1.x and 1.30.x.

I have not checked, but restore.php probably has the same problems with links.

[indigoxela]

I have not checked, but restore.php probably has the same problems with links.

The links in restore.php are OK.