Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Jira icon #33

Merged
merged 1 commit into from
Oct 19, 2020
Merged

feat: add Jira icon #33

merged 1 commit into from
Oct 19, 2020

Conversation

stefanbuck
Copy link
Contributor

@stefanbuck stefanbuck commented Oct 1, 2020 •
edited
Loading

Hey,

I'm using Badgen to generated badges used by https://pullrequestbadge.com/. One of the main use-cases of Pull Request Badge is adding a Jira badge to the pull request description. Therefore it would be super neat to have a Jira icon available.

Checklist

Preview

image

@vercel
Copy link

vercel bot commented Oct 1, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/badgen/badgen-icons/79zbrw0v5
✅ Preview: https://badgen-icons-git-add-jira-icon.badgen.vercel.app

@amio
Copy link
Member

amio commented Oct 7, 2020

Seems Jira's icon has changed (again)? https://www.atlassian.com/software/jira

@stefanbuck
Copy link
Contributor Author

Mhh if you scroll down on that page you see the logo I added. Also the android app is using this logo. The press kit page isn't helping either https://www.atlassian.com/de/company/news/press-kit

@amio
Copy link
Member

amio commented Oct 12, 2020

@stefanbuck Is this jira mobile logo?

image

@stefanbuck
Copy link
Contributor Author

Yes, but it's missing in their press kit page. To be honest I have no idea what the difference between all those JIRA products is. At work we use a self hosted JIRA instance and this is showing the logo I added which is inline with the mobile app logo. Maybe they are in the middle to roll out a new logo.

image

@stefanbuck
Copy link
Contributor Author

From their product page it seems like JIRA Software is what we want https://www.atlassian.com/de/software/jira

@stefanbuck
Copy link
Contributor Author

stefanbuck commented Oct 14, 2020 •
edited
Loading

I updated the logo to match the press kit version

image

amio
amio approved these changes Oct 19, 2020
View reviewed changes
Copy link
Member

@amio amio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks! @stefanbuck

@amio amio merged commit b636ad2 into badgen:master Oct 19, 2020
@stefanbuck stefanbuck deleted the add-jira-icon branch October 19, 2020 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amio amio amio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stefanbuck @amio