Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MBIN] Add subscribers badge #10270

Merged
merged 8 commits into from
Jun 23, 2024
Merged

[MBIN] Add subscribers badge #10270

merged 8 commits into from
Jun 23, 2024

Conversation

chris-y
Copy link
Contributor

@chris-y chris-y commented Jun 21, 2024

Add Mbin subscribers badge. This fixes #10264

Copy link
Contributor

github-actions bot commented Jun 21, 2024

Messages
📖 ✨ Thanks for your contribution to Shields, @chris-y!

Generated by 🚫 dangerJS against 12924e4

Copy link
Contributor

🚀 Updated review app: https://pr-10270-badges-shields.fly.dev

Copy link
Member

@PyvesB PyvesB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Overall looks good to me, left a few comments and suggestions.

services/mbin/mbin.service.js Outdated Show resolved Hide resolved
services/mbin/mbin.tester.js Outdated Show resolved Hide resolved
services/mbin/mbin.tester.js Outdated Show resolved Hide resolved
services/mbin/mbin.tester.js Outdated Show resolved Hide resolved
services/mbin/mbin.tester.js Outdated Show resolved Hide resolved
services/mbin/mbin.service.js Show resolved Hide resolved
@chris-y
Copy link
Contributor Author

chris-y commented Jun 23, 2024

Implemented all the requested changes.

Copy link
Member

@PyvesB PyvesB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, looks great!

@PyvesB PyvesB added this pull request to the merge queue Jun 23, 2024
Merged via the queue into badges:master with commit 92718ff Jun 23, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mbin
2 participants