perf: faster resetIconPosition
avoiding to parse path twice
#10497
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of #10488.
Just seen that PR and realized that the parsing of the path (d) is done twice. One in
svgpath(path)
and another insvgPathBbox(path)
assvgPathBbox
usessvgpath
internally.So I released a new version of
svg-path-bbox
that also acceptsSvgPath
interfaces to avoid the double parsing in situations like this. Instead of parsing again,svgpath
clones the segments and is so much faster.