deprecate [wheelmap] service #10538
Merged
deprecate [wheelmap] service #10538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
chris48s
commented
Sep 14, 2024
| @@ -1,56 +0,0 @@ | |||
| { | |||
There was a problem hiding this comment.
I started off by just removing WHEELMAP_TOKEN but I think this file is not actually doing anything useful. We certainly haven't been keeping it up to date.
By the looks of it, we put this in place to support Heroku review apps, which we don't use anymore.
PyvesB
approved these changes
Sep 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10404
Once we merge this we can remove
WHEELMAP_TOKENfrom prod/staging env vars on fly.ioSERVICETESTS_WHEELMAP_TOKENfrom GH Actions secretsSERVICETESTS_WHEELMAP_TOKENfrom Dependabot secrets