YouTube tests intermittently failing

[PyvesB]

🕚 When did the problem start?

Unsure on the exact date, the errors have been intermittent for several months as far as I can tell. Some problems were already reported here: #5842

📷 Live badge

https://img.shields.io/youtube/likes/abBdk8bSPKU?style=social

🔧 Is the live badge working?

The live badge is intermittently failing as well.

🔗 CircleCI link

https://app.circleci.com/pipelines/github/badges/daily-tests/833/workflows/eeeaf314-50d4-4e5c-83fe-c2f02c5d7197/jobs/1731

🪲 Stack trace

AssertionError: label mismatch: expected 'youtube' to equal 'votes'
    at Function._expectField (core/service-test-runner/icedfrisby-shields.js:69:51)
    at IcedFrisbyNock.<anonymous> (core/service-test-runner/icedfrisby-shields.js:53:26)
    at IcedFrisbyNock.<anonymous> (node_modules/icedfrisby/lib/icedfrisby.js:954:10)
    at invokeNextHook (node_modules/icedfrisby/lib/icedfrisby.js:1003:24)
    at /home/circleci/project/shields/node_modules/icedfrisby/lib/icedfrisby.js:1017:7
    at new Promise (<anonymous>)
    at IcedFrisbyNock._runHooks (node_modules/icedfrisby/lib/icedfrisby.js:976:12)
    at IcedFrisbyNock.run (node_modules/icedfrisby/lib/icedfrisby.js:1276:20)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:97:5)
    at async Context.<anonymous> (node_modules/icedfrisby/lib/icedfrisby.js:1348:9)

💡 Possible solution

We seem to be hitting the YouTube API rate limits. According to the API console:

The badges have gotten quite popular given that there are over 20000 requests per day with badges that were added less than a year ago!

We will basically need to follow the steps I documented here: #5101 (comment)

[PyvesB]

I've submitted the Quota Extension Form. Was more tedious than expected, new fields appear in the form as you select options. Let's see what comes out of it!

[PyvesB]

Great news! There's been a bit of back and forth with the YouTube compliance team initially not noticing the changes conducted as part of #6304, but after two weeks, I managed to get our quota increased from 10000 to 50000 daily requests. We may need to do a new increase request in a few months or years, but I would expect the process to be much more straightforward the second time round, provided our implementation remains at the same level of compliance.

The last few daily tests have not failed, and API errors are no longer being reported:

Closing this issue.