Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Netlify] added changes to use new color schema #6340

Merged
merged 1 commit into from
Apr 2, 2021
Merged

[Netlify] added changes to use new color schema #6340

merged 1 commit into from
Apr 2, 2021

Conversation

tarun7singh
Copy link
Contributor

@tarun7singh tarun7singh commented Apr 2, 2021 •
edited
Loading

Added new colour schema to fix netlify service badge.
Fixes #6334

@shields-ci
Copy link

Warnings
⚠️ This PR modified service code for netlify but not its test code.
That's okay so long as it's refactoring existing code.
Messages
📖 ✨ Thanks for your contribution to Shields, @tarun7singh!

Generated by 🚫 dangerJS against 05295d5

@PyvesB PyvesB added bug Bugs in badges and the frontend service-badge New or updated service badge labels Apr 2, 2021
PyvesB
PyvesB approved these changes Apr 2, 2021
View reviewed changes
Copy link
Member

@PyvesB PyvesB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this @tarun7singh ! Changes look good and tests pass, let's get this merged!

@PyvesB PyvesB merged commit 7d64e4f into badges:master Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PyvesB PyvesB PyvesB approved these changes

Assignees
No one assigned
Labels
bug Bugs in badges and the frontend service-badge New or updated service badge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Netlify badge down
3 participants
@tarun7singh @shields-ci @PyvesB