Add GitHub discussions total badge [GithubTotalDiscussions] #6472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PyvesB
reviewed
May 10, 2021
There was a problem hiding this comment.
Thanks for working on this @profgrammer! The badge works well in the review app and apart form a minor suggestion, the implementation looks good to me. 👍🏻
| data: Joi.object({ | ||
| repository: Joi.object({ | ||
| discussions: Joi.object({ | ||
| totalCount: Joi.number().required(), |
There was a problem hiding this comment.
Could nonNegativeInteger be used here?
PyvesB
approved these changes
May 10, 2021
|
@profgrammer if you've got a Twitter account, I can post a little something mentioning you for this new badge! |
I don't really use Twitter but I have an account: Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requestmethod - added the headers from the options body in the GitHub GraphQL V4 API