Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove [github] admin routes #7105

Merged
merged 1 commit into from
Oct 5, 2021
Merged

Conversation

chris48s
Copy link
Member

@chris48s chris48s commented Oct 4, 2021

As discussed in last ops meeting, we don't need this anymore. At this point it just represents risk.

TODO: remove SHIELDS_SECRET var in heroku after we deploy.

@chris48s chris48s added the core Server, BaseService, GitHub auth, Shared helpers label Oct 4, 2021
@shields-ci
Copy link

Warnings
⚠️

📚 Remember to ensure any changes to config.private in services/github/github-constellation.js are reflected in the server secrets documentation

⚠️ This PR modified the server but none of its tests.
That's okay so long as it's refactoring existing code.
Messages
📖 ✨ Thanks for your contribution to Shields, @chris48s!

Generated by 🚫 dangerJS against 77f392a

@@ -1,18 +0,0 @@
function constEq(a, b) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good riddance to this function!

Copy link
Member

@paulmelnikow paulmelnikow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌🏼

@chris48s chris48s merged commit 0ce9839 into badges:master Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Server, BaseService, GitHub auth, Shared helpers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants