Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor [reddit] improvements #7436

Merged
merged 3 commits into from
Dec 29, 2021
Merged

minor [reddit] improvements #7436

merged 3 commits into from
Dec 29, 2021

Conversation

chris48s
Copy link
Member

There are a couple of things from #7411 that we should apply here too

@shields-ci
Copy link

shields-ci commented Dec 28, 2021 •
edited
Loading

Messages
📖 ✨ Thanks for your contribution to Shields, @chris48s!

Generated by 🚫 dangerJS against 5938bca

calebcartwright
calebcartwright approved these changes Dec 28, 2021
View reviewed changes
Copy link
Member

@calebcartwright calebcartwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable to me. Probably worth keeping an eye out for other badges with similar rendering needs, in case it makes sense at some point to extract a new render helper

@chris48s chris48s added service-badge New or updated service badge squash when passing labels Dec 29, 2021
@repo-ranger repo-ranger bot merged commit bb5614d into badges:master Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calebcartwright calebcartwright calebcartwright approved these changes

Assignees
No one assigned
Labels
service-badge New or updated service badge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chris48s @shields-ci @calebcartwright