[GitHubGistStars] add GitHub Gist Stars #8471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris48s
reviewed
Oct 3, 2022
Comment on lines
12
to
13
| stargazerCount: Joi.number(), | ||
| url: Joi.string(), |
There was a problem hiding this comment.
Suggested change
| stargazerCount: Joi.number(), | |
| url: Joi.string(), | |
| stargazerCount: Joi.number().required(), | |
| url: Joi.string().required(), |
|
|
||
| static route = { | ||
| base: 'github/stars/gists', | ||
| pattern: ':gist', |
There was a problem hiding this comment.
Can we make the param :gistId to match
| } | ||
|
|
||
| static render({ stargazerCount, url }) { | ||
| return { message: metric(stargazerCount), link: [url] } |
There was a problem hiding this comment.
On the repo stars badge, we link the left side of the badge to the repo URL and the right side to /stargazers. Can we do the same thing for the gist version too please.
shields/services/github/github-stars.service.js
Lines 48 to 51 in 8e1680d
Gists also have a similar stargazers URL e.g: https://gist.github.com/maratori/47a4d00457a92aa426dbd48a18776322/stargazers
|
hi @chris48s , thanks for suggesting these changes. Please review the commit i just pushed. I have committed those changes and updated test cases as well and it passes the tests. |
chris48s
approved these changes
Oct 4, 2022
|
Thanks for merging my PR!🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #8269
added a new service class which extends
GithubAuthV4Service. It uses Github GraphQL API to query the stargazers count for the provided gist id. also added tester file for the same service class.screen-shots of example badges generated:
https://gist.github.com/47a4d00457a92aa426dbd48a18776322
https://gist.github.com/invalid-gist-id
