Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've merged a couple of PRs recently adding badges for GitHub gists.
Both of these made quite different decisions about what route to use. In particular, the stars one could have caused a conflict. Fortunately, you can't create a github username or team called "gists" 😌 . Bit of sloppy code review on my part there.
In this PR, I propose that the route we should use for github gist badges is
/github/gist/NOUN/PARAMETERS
withgist
being singularand then I've updated the 2 existing badges + added redirects.
I'm open to feedback on that. If we think that
/github-gist
,/github-gists
or/github/gists
would be better as a base than/github/gist
I am happy to update the PR. Whatever we decide, lets: pick one, use it consistently and continue to do so moving forwards.The other thing I've done in this PR is moved the gist badges to a subdir. The
/github
dir already has a lot of files in it, so I think it is useful to compartmentalise any further gist badges.