-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deprecate [tokei] service #9581
Conversation
Let's hold off on this for a bit as the Tokei maintainer has commented on relevant issues earlier today. In general I'd be in favor of deprecating this service, but only because:
However, I have to disagree with the performance characteristics portion of the reasoning. IMO this is another canonical example of the "good badge for us, but can be quite slow to respond on the first call" scenario, which is precisely the reasoning behind #9233. The tokei.rs web service does have caching enabled, so even if the first call for counting all the lines of the linux kernel is slow, the subsequent calls should return well within the window we'd need to satiate camo's timeout limit. AFAICT the service is working just fine and has been for a while, it's just that the But I'm 👍 with deprecating this if we can't get an answer on that and/or see a recurrence of the availability issues in the future |
Yeah - fair shout. If the other issues can be sorted, we could add an |
We removed all tokei badges from our repositories because they weren't working most of the time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd be in favour of removing this badge at this point, it's been broken for months now, latest issue being SSL handshakes with the API.
This might be a bit controversial, but..
This service has been out of action for some time. We've tried raising issues upstream with no response. Even when it has been "working", this has been an unreliable service, frequently producing unexpected results for users or not returning a response within a timeframe that allows us to render a useful response. This is unsurprising given it is essentially fetching an upstream repository (which might be very large) and counting the lines of code on-demand. If I pass https://github.com/torvalds/linux as the input, you're just not going to do that in 4 seconds or less, even if you did write the code in rust.
For example:
I think it is time to give up on this one.
Closes #7569