Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added up_message and down_message to [uptimerobotstatus] #9662

Merged
merged 3 commits into from
Jan 23, 2024

Conversation

filipgrudzien
Copy link
Contributor

@filipgrudzien filipgrudzien commented Oct 18, 2023

closes #8816

@github-actions
Copy link
Contributor

github-actions bot commented Oct 18, 2023

Warnings
⚠️ This PR modified service code for uptimerobot but not its test code.
That's okay so long as it's refactoring existing code.
Messages
📖 ✨ Thanks for your contribution to Shields, @filipgrudzien!

Generated by 🚫 dangerJS against c929a1d

@chris48s
Copy link
Member

Thanks. Could we also implement the up_color and down_color params.

Also, we'll need to add them to the documentation, but you can ignore that in this PR.
I'll deal with it as part of #9612

@filipgrudzien
Copy link
Contributor Author

Thanks. Could we also implement the up_color and down_color params.

Also, we'll need to add them to the documentation, but you can ignore that in this PR. I'll deal with it as part of #9612

Thanks. Could we also implement the up_color and down_color params.

Also, we'll need to add them to the documentation, but you can ignore that in this PR. I'll deal with it as part of #9612

Could You please review it, so we can merge it???

@chris48s chris48s changed the title feat: added up_message and down_message into uptimerobot-status [8816… feat: added up_message and down_message to [uptimerobot] Jan 23, 2024
@chris48s chris48s changed the title feat: added up_message and down_message to [uptimerobot] feat: added up_message and down_message to [uptimerobotstatus] Jan 23, 2024
@chris48s chris48s added the service-badge New or updated service badge label Jan 23, 2024
@chris48s chris48s added this pull request to the merge queue Jan 23, 2024
Merged via the queue into badges:master with commit e032f3d Jan 23, 2024
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service-badge New or updated service badge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add down_message and up_message to uptime robot badge
2 participants