Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update [Gitea] defaults to gitea.com #9872

Merged
merged 9 commits into from
Jan 8, 2024
Merged

Conversation

CanisHelix
Copy link
Contributor

@CanisHelix CanisHelix commented Jan 4, 2024

As https://gitea.com is a flagship instance of Gitea, updating the Gitea badges to default to gitea.com as a default. Added an extra test to each badge using the default instance.

Updated the message header to be clear about the default instance, and self-managed ones.

Updated tests to use try.gitea.io which is the official demo site, handling like a self-managed one.

Copy link
Contributor

github-actions bot commented Jan 4, 2024

Messages
📖 ✨ Thanks for your contribution to Shields, @CanisHelix!

Generated by 🚫 dangerJS against b1a08e1

@chris48s chris48s added the service-badge New or updated service badge label Jan 4, 2024
@chris48s
Copy link
Member

chris48s commented Jan 4, 2024

Can you have a look at the failing GiteaBase auth test before we review. Looks like the nock URL needs to be updated to account for these changes? Thanks

@chris48s chris48s changed the title Update Gitea defaults to gitea.com Update [Gitea] defaults to gitea.com Jan 4, 2024
@CanisHelix
Copy link
Contributor Author

Can you have a look at the failing GiteaBase auth test before we review. Looks like the nock URL needs to be updated to account for these changes? Thanks

I accidentally removed the protocol when changing the URL on the base auth test. Looks good now. Is there a way to perform a core test for just a single service? I tried npm run test:core -- --only=gitea but it still performs a test on all services.

Copy link
Contributor

github-actions bot commented Jan 6, 2024

🚀 Updated review app: https://pr-9872-badges-shields.fly.dev

services/gitea/gitea-helper.js Outdated Show resolved Hide resolved
services/gitea/gitea-languages-count.tester.js Outdated Show resolved Hide resolved
Copy link
Contributor

github-actions bot commented Jan 8, 2024

🚀 Updated review app: https://pr-9872-badges-shields.fly.dev

Copy link
Member

@chris48s chris48s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

latest changes look great - thanks

@chris48s chris48s added this pull request to the merge queue Jan 8, 2024
Merged via the queue into badges:master with commit 79dd749 Jan 8, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service-badge New or updated service badge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants