Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend github "commits since" badge --> count from latest release #993

Closed
tooomm opened this issue May 11, 2017 · 8 comments
Closed

extend github "commits since" badge --> count from latest release #993

tooomm opened this issue May 11, 2017 · 8 comments
Labels
service-badge New or updated service badge

Comments

@tooomm
Copy link
Contributor

tooomm commented May 11, 2017

Right now you need to provide a fixed tag to count from.
Can we have "latest" there as well, so it automatically counts from that and resets on release?

For example: https://img.shields.io/github/commits-since/SubtitleEdit/subtitleedit/latest.svg
instead having to update the badge tag every time since it's hard linked:
https://img.shields.io/github/commits-since/SubtitleEdit/subtitleedit/3.4.7.svg

@paulmelnikow
Copy link
Member

Neat idea! Would you like to open a pull request?

@paulmelnikow paulmelnikow added enhancement service-badge New or updated service badge labels Sep 22, 2017
@tooomm
Copy link
Contributor Author

tooomm commented Sep 26, 2017

I can't help with code, sry. :(

@jtmoon79
Copy link

jtmoon79 commented Dec 13, 2019

How do I use the latest feature of the commits since badge?

Using URL https://img.shields.io/github/commits-since/jtmoon79/goto_http_redirect_server/latest.svg the badge did not resolve to something meaningful (the badge reads no releases or repo not found).

Things I tried:

  • add tag 0.7.3 and release 0.7.3 (this does resolve for URL https://img.shields.io/github/commits-since/jtmoon79/goto_http_redirect_server/0.7.3.svg)
  • add tag latest and release latest that points to same commit as 0.7.3.

Still the URL .../latest.svg is never useful.

Project goto_http_redirect_server releases are here.

@tooomm
Copy link
Contributor Author

tooomm commented Dec 13, 2019

I think you have only tags in your repo, no releases @jtmoon79

@jtmoon79
Copy link

Thanks for the reply @tooomm .

I think you have only tags in your repo, no releases

The project releases page counts 2 releases https://github.com/jtmoon79/goto_http_redirect_server/releases 🤔

@tooomm
Copy link
Contributor Author

tooomm commented Dec 13, 2019

I can just tell that it works for me, but the release pages in the repo looks different: https://github.com/Cockatrice/Cockatrice/releases

-->
![](https://img.shields.io/github/commits-since/Cockatrice/Cockatrice/latest.svg)

@jtmoon79
Copy link

jtmoon79 commented Dec 14, 2019

I can just tell that it works for me, but the release pages in the repo looks different:

Indeed! I poked around briefly: it's a github oddity!
AFAICT, project tags will also populate project releases if there are no project releases. So just by adding tags, there appears to be releases. But they are ... fake? ... releases. They are something not quite releases. It's confusing.
I created a project release from the project releases page. Works now.

Thanks for replying @tooomm

@calebcartwright
Copy link
Member

I think the GitHub UX for releases is a fairly common source of confusion. I suspect this is because both tags and releases (if any exist) are listed in the default page, the "tags" tab filters down to releases-only but the "release" filters does not, not much visual distinction between the two especially for users that haven't worked with GH releases, etc.

For more info on the distinction: https://help.github.com/en/github/administering-a-repository/about-releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service-badge New or updated service badge
Projects
None yet
Development

No branches or pull requests

4 participants