Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom bucket URLs for Scoop version shield. #9982

Closed
jewlexx opened this issue Feb 22, 2024 · 2 comments · Fixed by #9984
Closed

Custom bucket URLs for Scoop version shield. #9982

jewlexx opened this issue Feb 22, 2024 · 2 comments · Fixed by #9984
Labels
good first issue New contributors, join in! service-badge New or updated service badge

Comments

@jewlexx
Copy link
Contributor

jewlexx commented Feb 22, 2024 •
edited
Loading

📋
In addition to referencing Scoop's bucket list, shields could take in a URL as a bucket parameter for the Scoop version shield.

After if (!bucketUrl), before throwing the error, shields could check if the bucket parameter is a valid GitHub URL, and attempt to extract the user & repo from that, using the same gitHubRepoRegExp, allowing users to reference buckets that are not in the official list.
@chris48s
Copy link
Member

Seems reasonable to me. Are you up for submitting a PR?

@chris48s chris48s added service-badge New or updated service badge good first issue New contributors, join in! labels Feb 22, 2024
@jewlexx
Copy link
Contributor Author

jewlexx commented Feb 23, 2024

Sure, I'll see what I can do.

@jewlexx jewlexx mentioned this issue Feb 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue New contributors, join in! service-badge New or updated service badge
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added custom bucket url support for [Scoop]
2 participants
@chris48s @jewlexx