Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show full star count #999

Closed
mxstbr opened this issue May 24, 2017 · 8 comments
Closed

Show full star count #999

mxstbr opened this issue May 24, 2017 · 8 comments
Labels
question Support questions, usage questions, unconfirmed bugs, discussions, ideas

Comments

@mxstbr
Copy link

mxstbr commented May 24, 2017

It'd be awesome to have an option to show the full star count rather than the abbreviated version, i.e. rather than showing "Stars 7k" I want to see "Stars 7,278". 😊

screen shot 2017-05-24 at 12 24 41

Love this service, thanks so much for making this a thing!

@paulmelnikow
Copy link
Member

Hi, thanks for your suggestion. The full count makes the badges a bit messier, so I'd tend to argue for leaving them as they are.

@paulmelnikow paulmelnikow added frontend The Docusaurus app serving the docs site service-badge New or updated service badge labels Sep 22, 2017
@ritwickdey
Copy link
Contributor

Hi, @paulmelnikow
Honestly, I also want the feature. It should depends how customer wants to see it.

I prefer 5.21K or 2.45M (2 digit after point).

Just a suggestion: As we can change the label of badge using optional parameter, it will be better if it can be customize using optional parameters (eg.?dataFormat=) and as there has a standard function metric(), if we pass the data object in the metric() function as an optional parameter and the metric() will return the value according to data.dataFormat.

@paulmelnikow
Copy link
Member

This request is for https://github.com/mingrammer/go-web-framework-stars. If the Shields badge designs were integrated into that page, how would it look?

The more I look at it, the more I'm not convinced that for projects with a lot of forks, 12517, 12136 is more helpful or legible than 12.5k, 12.1k.

It should depends how customer wants to see it.

The project owner is a customer, but so is a visitor who is looking at the readme. Providing the visitor a consistent experience across projects is also part of our goal of providing consistent, readable badges.

@ritwickdey
Copy link
Contributor

I got your point (y) :)

@paulmelnikow paulmelnikow added core Server, BaseService, GitHub auth, Shared helpers and removed frontend The Docusaurus app serving the docs site service-badge New or updated service badge labels Oct 10, 2017
@RedSparr0w
Copy link
Member

IMO badges should be able to display a decimal if they are < 10 eg: 1.2k 2.5k 11k 120k,
As there is quite a big difference between 1k and 1.4k where as not such a big difference between 12k and 13k in terms of percentage.
For example I have a chrome extension which i use the badge for, and it all of a sudden jumped from 1k to 2k which looked a bit strange, I also don't get to see it slowly progress, only get to see the major jumps (unless i goto the dashboard)

But i agree it does not look as consistent which is a primary goal of the project.




@paulmelnikow
Copy link
Member

My question is still this:

This request is for https://github.com/mingrammer/go-web-framework-stars. If the Shields badge designs were integrated into that page, how would it look?

If anyone would like to mock something up (using static badges, say), I'd be happy to consider it.

@the-j0k3r
Copy link

the-j0k3r commented Jul 1, 2018

This is one of the most important aspects of starring to see a more accurate count rather than something rounded up by as much as 200 votes, a project with 2.800 stars is seen as 3K, I would say thats neither accurate nor realistic.

Please stop rounding things up. Else may as well just invent a star count and make a full static image badge, so that way I may show visitors I have 99999 stars when in hypothetically have 99. I would also be rounding things up by any arbitrary number not defined by some faulty logic other than my own.

If anyone would like to mock something up (using static badges, say), I'd be happy to consider it.

I dont understand the issue. see

Star

vs

GitHub stars

both live badges except using http://github-svg-buttons.herokuapp.com the design choices are limited which is just not ideal, but at least star counts are accurate and not made up.

@paulmelnikow paulmelnikow mentioned this issue Jan 4, 2019
10 tasks
@paulmelnikow paulmelnikow added question Support questions, usage questions, unconfirmed bugs, discussions, ideas and removed core Server, BaseService, GitHub auth, Shared helpers labels Jan 8, 2019
@paulmelnikow
Copy link
Member

Hi all, we understand you may be disappointed that Shields is not offering this feature. However we are offing a workaround: the Endpoint badge. You can use it with tools like RunKit and Jupyter Kernel Gateway to implement the exact badge content and logic you want, while letting Shields take care of formatting, rendering, and caching.

If you decide to use the new feature, your feedback is much appreciated! Please feel free to comment on the Endpoint beta issue if you have feedback or questions about how to use it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Support questions, usage questions, unconfirmed bugs, discussions, ideas
Projects
None yet
Development

No branches or pull requests

5 participants