Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate schema in CI #71

Closed
disrupted opened this issue Jan 30, 2023 · 2 comments · Fixed by #197
Closed

Generate schema in CI #71

disrupted opened this issue Jan 30, 2023 · 2 comments · Fixed by #197
Assignees
@sujuka99
Labels
area/CI Relates to GitHub actions

Comments

@disrupted
Copy link
Member

Create a new CI workflow that runs from main to re-generate the kpops schemas (for pipeline.yaml and config.yaml), then commit and push those changes.
@disrupted disrupted added the area/CI Relates to GitHub actions label Jan 30, 2023
@disrupted disrupted mentioned this issue Jan 30, 2023
Merged
@disrupted disrupted added this to the v1.0 milestone Jan 31, 2023
@disrupted disrupted removed this from the v1.0 milestone Mar 1, 2023
This was referenced Apr 3, 2023
Open
Closed
@sujuka99
Copy link
Contributor

sujuka99 commented Apr 11, 2023 •
edited
Loading

Should I do the same as we did for the docs?

i.e. generate it in the pre-commit hooks, instead of in the CI

@disrupted
Copy link
Member Author

Should I do the same as we did for the docs?

i.e. generate it in the pre-commit hooks, instead of in the CI

sounds reasonable to me 👍🏻

@sujuka99 sujuka99 mentioned this issue Apr 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sujuka99 sujuka99

Labels
area/CI Relates to GitHub actions
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Generate schema in CI bakdata/kpops
2 participants
@disrupted @sujuka99