Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README.md contains YouTube Thumbnail Is Misleading #7341

Open
chauhankiran opened this issue Jul 22, 2024 · 1 comment · May be fixed by #7354
Open

README.md contains YouTube Thumbnail Is Misleading #7341

chauhankiran opened this issue Jul 22, 2024 · 1 comment · May be fixed by #7354

Comments

@chauhankiran
Copy link

Node version:
Sails version (sails): 1.5.11
ORM hook version (sails-hook-orm):
Sockets hook version (sails-hook-sockets):
Organics hook version (sails-hook-organics):
Grunt hook version (sails-hook-grunt):
Uploads hook version (sails-hook-uploads):
DB adapter & version (e.g. [email protected]):
Skipper adapter & version (e.g. [email protected]):


On the README.md page, within "Your First Sails Project" section, there is thumbnail for the YouTube video. But, clicking on this thumbnail redirect to the official website which is misleading as it is expected to open the 'Intro to Sails.js' video in YouTube as per thumbnail.

We should either

  1. Remove the thumbnail
  2. Add the original video link. But, that video is at least few years old and might not that much useful.

Personal suggestion is option 1 from above. I can make a PR for the same.

@sailsbot
Copy link

@chauhankiran Thanks for posting! We'll take a look as soon as possible.

In the mean time, there are a few ways you can help speed things along:

  • look for a workaround. (Even if it's just temporary, sharing your solution can save someone else a lot of time and effort.)
  • tell us why this issue is important to you and your team. What are you trying to accomplish? (Submissions with a little bit of human context tend to be easier to understand and faster to resolve.)
  • make sure you've provided clear instructions on how to reproduce the bug from a clean install.
  • double-check that you've provided all of the requested version and dependency information. (Some of this info might seem irrelevant at first, like which database adapter you're using, but we ask that you include it anyway. Oftentimes an issue is caused by a confluence of unexpected factors, and it can save everybody a ton of time to know all the details up front.)
  • read the code of conduct.
  • if appropriate, ask your business to sponsor your issue. (Open source is our passion, and our core maintainers volunteer many of their nights and weekends working on Sails. But you only get so many nights and weekends in life, and stuff gets done a lot faster when you can work on it during normal daylight hours.)
  • let us know if you are using a 3rd party plugin; whether that's a database adapter, a non-standard view engine, or any other dependency maintained by someone other than our core team. (Besides the name of the 3rd party package, it helps to include the exact version you're using. If you're unsure, check out this list of all the core packages we maintain.)

Please remember: never post in a public forum if you believe you've found a genuine security vulnerability. Instead, disclose it responsibly.

For help with questions about Sails, click here.

xooolod added a commit to xooolod/sails that referenced this issue Oct 30, 2024
Updated README.md since youtube thumbnail is misleading

Close balderdashy#7341
@xooolod xooolod linked a pull request Oct 30, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants