feat(website): implement group topic page #113

cokemine · 2022-08-03T06:38:45Z

/group/topic/${topicId}

closes #112

codecov · 2022-08-03T06:40:19Z

Codecov Report

Base: 92.00% // Head: 92.46% // Increases project coverage by +0.46% 🎉

Coverage data is based on head (b38c505) compared to base (ac8b427).
Patch coverage: 96.52% of modified lines in pull request are covered.

❗ Current head b38c505 differs from pull request most recent head 4b156b8. Consider uploading reports for the commit 4b156b8 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #113      +/-   ##
==========================================
+ Coverage   92.00%   92.46%   +0.46%     
==========================================
  Files          70       76       +6     
  Lines        3688     4006     +318     
  Branches      423      463      +40     
==========================================
+ Hits         3393     3704     +311     
- Misses        293      300       +7     
  Partials        2        2

Impacted Files	Coverage Δ
packages/utils/pages.ts	`62.50% <ø> (ø)`
.../pages/index/group/components/ClampableContent.tsx	`71.08% <38.46%> (ø)`
packages/utils/bbcode/convert.ts	`94.63% <84.61%> (-0.27%)`	⬇️
packages/client/topic.ts	`93.75% <93.75%> (ø)`
packages/design/components/Topic/Comment.tsx	`99.45% <99.45%> (ø)`
packages/client/common.ts	`100.00% <100.00%> (ø)`
packages/client/user.ts	`92.85% <100.00%> (-1.27%)`	⬇️
packages/design/components/Layout/index.tsx	`100.00% <100.00%> (ø)`
packages/design/components/Pagination/index.tsx	`98.37% <100.00%> (+0.05%)`	⬆️
packages/design/components/RichContent/index.tsx	`100.00% <100.00%> (ø)`
... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

…t/group-topic

.github/workflows/preview-storybook.yml

…t/group-topic

trim21 · 2022-11-21T15:48:49Z

用post_id假装（

trim21 · 2022-11-21T15:58:24Z

https://pr-113-sites--bangumi-next.netlify.app/group/topic/371602#post_2092004 这个浏览器的定位效果好实现吗

cokemine · 2022-11-21T16:14:00Z

https://pr-113-sites--bangumi-next.netlify.app/group/topic/371602#post_2092004 这个浏览器的定位效果好实现吗

应该只能 SSR 吧 @Ayase-252

  useEffect(() => {
    const anchor = window.location.hash.slice(1);
    document.getElementById(anchor)?.scrollIntoView(true);
  }, [topicDetail]);

这样可以，但是感觉会有点问题

trim21 · 2022-11-21T18:38:08Z

🤔 要不先review一下这个，然后用这个来发请求 #200

…t/group-topic

trim21 · 2022-11-27T13:20:28Z

除了定位到评论，其他的看起来ok。

我记得chrome有个非标的API scrollIntoViewIfNeeded可用

Ayase-252 · 2022-11-28T03:02:16Z

scrollIntoView 有啥问题吗？感觉定位缺个高亮的样式，可以先记个 issue 以后改

cokemine · 2022-11-28T03:35:33Z

https://next.bgm.tv dev不了了，是后端改过什么东西吗 description : "bad referer, cross-site api request is not allowed"

trim21 · 2022-11-28T13:27:05Z

后端没改过什么东西。

vite的proxy倒是改过，是这个的问题？

cokemine · 2022-11-28T14:11:49Z

应该不是。vite.config.ts 改过之后没有出现问题

trim21 · 2022-11-28T14:32:43Z

后端也没改什么东西，好久没打新tag了

trim21 · 2022-11-28T17:01:41Z

的确是vite配置错了

Ayase-252 · 2022-11-29T14:25:14Z

未登录的情况下隐藏回复和 +1 按钮吧。

packages/design/components/Topic/Comment.stories.tsx

packages/design/components/Topic/CommentInfo.tsx

…t/group-topic

Ayase-252

没其他问题

Ayase-252 · 2022-11-30T15:42:56Z

packages/design/components/Layout/index.tsx

+import React from 'react';
+
+export interface LayoutProps {
+  type: 'alpha' | 'beta';


beta 好像没有用到？话说 alpha 是什么意思？

我看了看小组页面、小组主题帖、和搜索页面的布局是一样的。条目具体信息会用另一套布局。应该不会有太多布局就放着复用了（

…t/group-topic

feat: new folder

0e3a8b5

cokemine added 8 commits August 22, 2022 23:05

Merge branch 'master' of https://github.com/bangumi/frontend into fea…

9da3b46

…t/group-topic

wip

909002e

fix: fix style import

5c444b1

update api

f22e6d4

refactor: replyinfo

657a9cb

wip: add comments

540fa34

add comment reply

75c95c9

revert ci changes

45ce877

trim21 reviewed Aug 31, 2022

View reviewed changes

.github/workflows/preview-storybook.yml Outdated Show resolved Hide resolved

cokemine added 19 commits August 31, 2022 22:38

fix some styles

15ce6ca

fix reply floor

1d1d401

add reply collapse

cd06def

update styles

de31299

add button group

1028ff9

fix

ec9b9f6

add reply editor

3a0ea4f

fix bbcode editor style

783b35f

add reply editor

e3c1b62

add deleted state

5d44f1f

Merge branch 'master' of https://github.com/bangumi/frontend into fea…

9bf3939

…t/group-topic

add special comment state

822b8b1

refactor

c17ce25

wip: right col

7155beb

group info

bb7d72b

wip

592a50f

wip

1e5b3b4

add reopen state

bf2c9d3

fix button style

974e4de

cokemine added 4 commits November 22, 2022 19:53

Merge branch 'master' of https://github.com/bangumi/frontend into fea…

4521a25

…t/group-topic

update

e862555

fix test

c2261be

Merge branch 'master' of https://github.com/bangumi/frontend into fea…

7864ef8

…t/group-topic

Merge branch 'master' into feat/group-topic

d9b7d9b

pull-request-size bot added the size/XXL label Nov 28, 2022

update

ab670f1

Ayase-252 reviewed Nov 29, 2022

View reviewed changes

packages/design/components/Topic/Comment.stories.tsx Show resolved Hide resolved

Ayase-252 reviewed Nov 29, 2022

View reviewed changes

packages/design/components/Topic/CommentInfo.tsx Show resolved Hide resolved

cokemine added 2 commits November 30, 2022 09:53

Merge branch 'master' of https://github.com/bangumi/frontend into fea…

2f3c8b9

…t/group-topic

update

053ab01

cokemine force-pushed the feat/group-topic branch from 97cdce0 to 053ab01 Compare November 30, 2022 02:24

Ayase-252 reviewed Nov 30, 2022

View reviewed changes

cokemine added 3 commits December 1, 2022 10:14

update enum

7d4f7e1

Merge branch 'master' of https://github.com/bangumi/frontend into fea…

b38c505

…t/group-topic

update story

4b156b8

Ayase-252 approved these changes Dec 1, 2022

View reviewed changes

trim21 merged commit bee42ce into bangumi:master Dec 1, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(website): implement group topic page #113

feat(website): implement group topic page #113

cokemine commented Aug 3, 2022

codecov bot commented Aug 3, 2022 •

edited

Loading

trim21 commented Nov 21, 2022

trim21 commented Nov 21, 2022

cokemine commented Nov 21, 2022 •

edited

Loading

trim21 commented Nov 21, 2022

trim21 commented Nov 27, 2022

Ayase-252 commented Nov 28, 2022

cokemine commented Nov 28, 2022

trim21 commented Nov 28, 2022 •

edited

Loading

cokemine commented Nov 28, 2022

trim21 commented Nov 28, 2022

trim21 commented Nov 28, 2022

Ayase-252 commented Nov 29, 2022

Ayase-252 left a comment

Ayase-252 Nov 30, 2022

cokemine Dec 1, 2022

feat(website): implement group topic page #113

feat(website): implement group topic page #113

Conversation

cokemine commented Aug 3, 2022

codecov bot commented Aug 3, 2022 • edited Loading

Codecov Report

trim21 commented Nov 21, 2022

trim21 commented Nov 21, 2022

cokemine commented Nov 21, 2022 • edited Loading

trim21 commented Nov 21, 2022

trim21 commented Nov 27, 2022

Ayase-252 commented Nov 28, 2022

cokemine commented Nov 28, 2022

trim21 commented Nov 28, 2022 • edited Loading

cokemine commented Nov 28, 2022

trim21 commented Nov 28, 2022

trim21 commented Nov 28, 2022

Ayase-252 commented Nov 29, 2022

Ayase-252 left a comment

Choose a reason for hiding this comment

Ayase-252 Nov 30, 2022

Choose a reason for hiding this comment

cokemine Dec 1, 2022

Choose a reason for hiding this comment

codecov bot commented Aug 3, 2022 •

edited

Loading

cokemine commented Nov 21, 2022 •

edited

Loading

trim21 commented Nov 28, 2022 •

edited

Loading