-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
We are experiencing weird commit re-writing with homu, which causes commits to be broken (not build wise) #126
Comments
I would like to also add that the commits were fine before: https://github.com/matthiasbeyer/imag/pull/125 She also does not actually merge the pr after pushing into master. This has been a problem for about 4-5 days, looking at your commit history it seems something broke. |
Why are we getting no response here, @barosl? |
we had the same issue here: projectatomic/atomic@1645062 The original commit was correctly GPG signed: giuseppe/atomic@0165fa5 |
QDRy90FpnOlyCYNUWnWoCnkLEym9RLB/gUP6cs+0uH6Qlu3tS0bjiWbHR8RxOKKC THH5vqR+zYj8JWQR3bpVh1gIlQFxhALhWdAfS3eLSMM9fHtYemozHw5gFGSClXYV tbmp8G2hKX7WdmAK68NUU5fCkHORR0G8cpyI/gkHfQdDGQikuDIAbF3NNG2aRrmv lWTo6Wd1XtGpoygUuBuAcMnwCC3O2m1wF8M09jwOLX533v89zEpmjYbh8/YMOHT6 lcNHTOMqzQcjFym10fiEBpqv7jQJ5bgv7CmZOF6stqkEZdOXkI59zI85h4+58KI6 6qPjf673Mv26sqhuzwhkDQ912RxesoEP+vGQYg5N0KdDPfR6DlNj22fSwZwMJXap 9/H8VlttfbHg6HDTb0JCwgouPEMA7LCxD9xaluE82NxLRyu8ijImiBNi+oyHnSTE /mMYRXA/cZy3dC7LJjrsL0I+ylpTe3lSh7AR8kiP7zsEe5ctnH3LNE33BOMFRJRw 9QqEjPNuyLTI2B39UW/MpFJbA+NMrwP7vqe2yrqJa1x7SVJVz//zzjLTkZ+iS3mV 34Wd0u08jxgvlesdMBjL7Qu7RSNn5aPlz9rD3WO9l9XZuSTaD29OypKKCMW0Nuwl ZqEOGein5AccMr9Wzn8k =kYfC -----END PGP SIGNATURE----- fix typo Closes: #179 Approved by: rhatdan
Please have a look at the git history of https://github.com/matthiasbeyer/imag
Homu merged commits from @TheNeikos which are signed with GPG. Homu somehow re-writes these commits before merging. This results in the first two lines of the GPG signature to be removed, which breaks the whole commit.
The commit IDs are not the same anymore than from the hashes of the original commits, so we assume that humo rewrites commits.
Please fix this, we can not trust homu anymore and I will remove humo from my repository now because of this.
The text was updated successfully, but these errors were encountered: