Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doesn't work on next Rails #139

Open
ghiculescu opened this issue Aug 5, 2024 · 2 comments · May be fixed by #140
Open

Doesn't work on next Rails #139

ghiculescu opened this issue Aug 5, 2024 · 2 comments · May be fixed by #140

Comments

@ghiculescu
Copy link

Since rails/rails#52428, Marginalia doesn't work on some queries. I think the fix is to alias internal_exec_query instead of exec_query here. Does that sound right to you @byroot ? (Presumably same goes for update/deletes.)
ghiculescu added a commit to ghiculescu/marginalia that referenced this issue Aug 5, 2024
@ghiculescu
Make it work with next Rails
6b2b2ea 
Fix basecamp#139
@ghiculescu ghiculescu linked a pull request Aug 5, 2024 that will close this issue
Open
@byroot
Copy link
Collaborator

byroot commented Aug 5, 2024

Marginalia is deprecated in favor of https://api.rubyonrails.org/classes/ActiveRecord/QueryLogs.html, I don't see much point making it compatible with Rails 8.0.

@ghiculescu
Copy link
Author

I guess it’s time to switch over 😿

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make it work with next Rails ghiculescu/marginalia
2 participants
@byroot @ghiculescu