Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python client adds unexpected riak@ to certificate CN check [JIRA: CLIENTS-753] #433

Closed
kesslerm opened this issue Feb 8, 2016 · 0 comments

Comments

@kesslerm
Copy link

kesslerm commented Feb 8, 2016

In https://github.com/basho/riak-python-client/blame/master/riak/transports/pbc/connection.py#L133 the prefix riak@ is added to the SSL certificate host check. Therefore the CN or SAN records of the server certificate need to be riak@<hostname> or riak@<ip_addr>`, whereas it's common practice to issue server certificate for the host-name or ip address of the server. The client behaviour is therefore unexpected. Furthermore, this behaviour is unique to the python and ruby clients and generally completely undocumented in Riak's server documentation.

The test certificate has a CN record of [email protected], which should be changed accordingly.

@Basho-JIRA Basho-JIRA changed the title Python client adds unexpected riak@ to certificate CN check Python client adds unexpected riak@ to certificate CN check [JIRA: CLIENTS-753] Feb 8, 2016
@lukebakken lukebakken added this to the riak-python-client-2.4.2 milestone Feb 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants