Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import - sharing annotation in team #118

Closed
fab6 opened this issue Jan 1, 2022 · 13 comments
Closed

Import - sharing annotation in team #118

fab6 opened this issue Jan 1, 2022 · 13 comments

Comments

@fab6
Copy link

fab6 commented Jan 1, 2022

Hi,

may I ask if I can share my annotations e.g. with a colleague? I saw the exporting option, but did not see e.g. any import?

Thank you in advance!
Fab

@cage2
Copy link
Collaborator

cage2 commented Jan 1, 2022 via email

@fab6
Copy link
Author

fab6 commented Jan 2, 2022

Thank you for your quick reply... I am not so sure yet, what the best way would be. Your approach to discard overlapping annotations from the import would certainly be one option.

Maybe there is an option two work with two databases; one standard + merged and one solely imported one. And the user could switch the database when needed.

@cage2
Copy link
Collaborator

cage2 commented Jan 2, 2022

Hi!

Thank you for your quick reply...

Thanks to you for using this library!

I am not so sure yet, what the best way would be. Your approach to discard overlapping annotations from the import would certainly be one option.

OK! I think, i am going to start exploring this way.

Maybe there is an option two work with two databases; one standard + merged and one solely imported one. And the user could switch the database when needed.

There is a command called annotate-switch-db; maybe this message:

#68 (comment)

could contains useful information to get something similar to what you wrote above?

Bye!
C.

@bastibe
Copy link
Owner

bastibe commented Jan 3, 2022

It might also be possible to merge overlapping annotations into one longer annotation that contains both messages.

@cage2
Copy link
Collaborator

cage2 commented Jan 3, 2022

Hi @bastibe

It might also be possible to merge overlapping annotations into one longer annotation that contains both messages.

This is a good idea! And perhaps not too difficult to implement. :)
Maybe both strategy could be implemented using a customizable variable to let the user choose their favorite.

Bye!
C.

@fab6
Copy link
Author

fab6 commented Jan 3, 2022

Hi, the merging sounds quite similar to the way word is doing it with its comments... and it sounds quite powerful.

@cage2
Copy link
Collaborator

cage2 commented Jan 4, 2022

Hi!

Both of you convinced me that the proposal from @bastibe is the best solution! :)

Bye!
C.

@cage2
Copy link
Collaborator

cage2 commented Jan 10, 2022

Hi!

I am starting to work on this: @fab6 , you are very welcome (if you have time, of course :-)) to check the PR #120 for suggestions or criticism.

Bye!
C.

@fab6
Copy link
Author

fab6 commented Jan 11, 2022

thanks, I will see how much I can help

@cage2
Copy link
Collaborator

cage2 commented Jan 17, 2022

Hi!

The patch is ready for testing. I checked a couple of scenarios and there was problems that i hope i have fixed with the last commit. But some other bugs could be still hiding! :)

Bye!
C.

@cage2
Copy link
Collaborator

cage2 commented Jan 28, 2022

Hi @fab6 !

I believe that the patch in #120 could implement your suggestion, i am closing this issue for now but if you think there is something wrong with the patch feel free to reopen this report so that we can discuss improvements!

Bye and thanks for the suggestion!
C.

@cage2 cage2 closed this as completed Jan 28, 2022
@fab6
Copy link
Author

fab6 commented Jan 28, 2022

Hi,
thank you and excuse me, that I could not support directly, I am testing it after my vacation time.
Thank you!

@cage2
Copy link
Collaborator

cage2 commented Jan 28, 2022

Hi @fab6 !

No need to excuse at all! Take your time, and wish you happy vacations! :-) :-)
C.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants