Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Datez #12

Open
Mazyod opened this issue Jan 19, 2017 · 1 comment
Open

Integrate Datez #12

Mazyod opened this issue Jan 19, 2017 · 1 comment
Assignees

Comments

@Mazyod
Copy link
Collaborator

Mazyod commented Jan 19, 2017

I would like to propose integrating Datez into the app for simpler date calculations. Calculations from the legacy codebase use hard coded integers, which fails in case DST kicks in. In general, it's best to use NSCalendar APIs to calculate dates.

If we agree to integrate it, we probably would need to integrate Cocoapods as well, since it's the easiest way to keep the dependency in check.

@z3bi thoughts?

@z3bi
Copy link
Contributor

z3bi commented Jan 19, 2017

We should definitely use the NSCalendar and NSDateComponents API to do all date manipulation. Datez seems like a convenient wrapper around those existing frameworks and makes it more concise to do the kind things we need. Sounds good to me. I would also agree about using Cocoapods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants