-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prayer times are wrong(?) #154
Comments
I have noticed this as well. In the Philadelphia, USA area the Isha time is off by about 9 minutes in May/June. I notice that the Turkey calculation method uses manual adjustments, and Isha doesn't have a manual adjustment. |
@sami155 please take screenshots from your calculation settings page with advanced section open (to see what are your calculation settings) |
The settings are unchanged. But for German cities (e.g Berlin, Frankfurt, Munich) the differences are huge. Ok, the difference is big, but a few days ago (the time that I posted the issue, the difference was massive) It is pretty unreliable rn. (Btw, the search for changing my location is incredibly slow in the newest beta version. It takes 2-5 minutes for the Cities to pop up) |
@sami155 please send screenshot of your calculation settings (with advanced section visible) also the slowness is because of Geonames website, I'm working on alternatives as we speak :) |
|
It seems the issue has been long around. see these links: |
Hmmm. Ok that is not good. What can we do about it? Maybe we could try to contact the "devs" behind the Dinanet website? For now idk what I will be doing. Maybe I will be using another calculaton method whose times are most similar to Dianet and reliable.... |
Can you ask here to see what method and angle they exactly use? https://www.iisev.de/wissensportal/artikel/die-zeit-des-morgengebets-und-des-imsks-in-deutschland/ their times match diyanet times, and they say they use angle 13 but it doesn't give correct results |
this is the info I have found so far, thanks to the info and link @meezaan has given me on discord: https://web.archive.org/web/20201127204050/https://fetva.diyanet.gov.tr/Cevap-Ara/4093/45--enlemin-otesinde-namaz-vakitleri?enc=QisAbR4bAkZg1HImMxXRn2t8ij%2beDtMkJdRGirgyeb8%3d
|
This information seems like it is enough to make modifications to the calculations when method is "Turkey" and the longitude criteria is met. |
So finally I found the official API from Diyanet. Idk why it took so long to find it: https://github.com/DinIsleriYuksekKurulu/AwqatSalah And here is the website for it: https://awqatsalah.diyanet.gov.tr/index.html I hope you can integrate the API into the project Apparently (if i understood it correctly) the API has a limit of 5 requests for public users, and 100 if you register. Because on how limited this is, a solution could maybe be, to ask the dev directly. |
Using an online api is not an option for me, it has to be completely offline I'll look into implementing it if there's no activity in a month or so on adhan js |
I tried adding the rules a, b and c from https://kurul.diyanet.gov.tr/Karar-Mutalaa-Cevap/4093/45-enlemin-otesinde-namaz-vakitleri for latitudes over 62, I ignored the number and used 62 (rule d) though one strange thing I noticed is that it seems they didn't take into account the -62 < and < -45 latitudes (not sure if this is even correct, but worth mentioning) even though I got closer to the times on Diyanet on locations other than turkey, there were still 3-10 minutes difference between the new times and the times on Diyanet website some places that had different Isha times benefitted from setting Isha angle to 16.2, but couldn't find why it would on some cases and not on others this is as far as I could get to getting close to the Diyanet website |
someone sent me this via pdf via email, may be useful: it seems the content of the pdf can be found online here: https://www.ditiblyon.fr/avrupa-takvimlerindeki-imsak-yatsi-vakitlerine-iliskin-aciklama/ edit: the link in previous comment seems to be more useful than this |
well it seems diyanet website itself does not use rules a b c (for frankfurt at least, that I'm checking), |
Hello, so im using the app "Al-Azan" from @meypod. Great app. And it also uses your libary for getting its Prayer times. But what I noticed is, that your calculated prayer times for the Turkish Diyanet are wrong.
When compared with their App or website, you can see that the times are mostly wrong. Sometimes just a few minutes, sometimes like 20+ minutes. (Screenshots below) Its the same for every German city.
Also when I visited other websites, not from Diyanet and compared their times with other calculation methods from your libary, it was also different.
Maybe its an issue with your libary, maybe from the app im using, but I'm thanking for any help
The text was updated successfully, but these errors were encountered: