Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: bayes_opt.util.acq_max Lacking Some Forward Compatibility with Scipy L-BFGS-B Minimizer #320

Closed
ngupta20 opened this issue May 31, 2022 · 1 comment

Comments

@ngupta20
Copy link

ngupta20 commented May 31, 2022

Description

Scipy made a change starting in version 1.7.2 that ensures the attribute .fun of an OptimizeResult object returned by _minimize_lbfgsb is scalarized (from a low/zero-dimensional np.ndarray to a float). The pertinent change in scipy.optimize._differentiable_functions can be viewed here.

Reproduction

I happened upon the effects of the new scipy version when running a standard register-suggest on an updated environment.
This notebook contains the error reproduction and a view of the stack trace.

Suggested Change

I posted a low-impact, version-gnostic, and backwards compatible PR (#319). Apologies in advance if this breaks a style requirement.

This PR is an explicit variant of #303.

A Note

Thank you all for BayesianOptimization, it's a fantastic contribution!

Thanks,

Nandish Gupta
Data Science Engineer, SolasAI

@bwheelz36
Copy link
Collaborator

thanks, as noted on the pull request #319 I used #303 simply because it was submitted first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants