Use rules_shell for shell targets #1960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
reviewed
Oct 19, 2024
There was a problem hiding this comment.
This change unfortunately isn't fully backwards compatible unless we find a way to invoke rules_shell's dependency macros from the existing WORKSPACE dependency macros of gazelle. We shouldn't have to change WORKSPACE to get this to work.
Could you give that a try?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What package or component does this PR mostly affect?
all
What does this PR do? Why is it needed?
Adds an explicit load (and dep) for sh_binary, which is no longer packaged inside Bazel 8. This is backwards-compatible with Bazel 7.
Which issues(s) does this PR fix?
Fixes #1959
Other notes for review