Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please support excluding certain paths from vendor/ in Gazelle #1103

Closed
jmillikin-stripe opened this issue Dec 5, 2017 · 2 comments
Closed

Comments

@jmillikin-stripe
Copy link
Contributor

This is probably easiest to solve as part of #859

https://github.com/kubernetes/client-go has unusual dependency handling. It vendors most of its dependencies, but leaves some deps un-vendored. This prevents Gazelle from generating BUILD files, because some externals need to use //vendor/foo.com/bar and others need @com_foo_bar//.

It would be nice if Gazelle (via go_repository) could be told that certain external dependencies should be resolved as Bazel deps, even if the overall repository is having BUILD files generated with vendored deps.

@jayconrod
Copy link
Contributor

I think #859 will fix this if Gazelle is run in external mode. Dependencies that can be resolved using the vendor directory will be, anything unresolved will go to an external dependency.

I'll leave this open to be sure to verify this case when that issue is closed.

@jayconrod
Copy link
Contributor

Closing old Gazelle issues. This should be working now. If not, please file a new issue at bazelbuild/bazel-gazelle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants