Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make importpath optional for go_binary and go_test #1125

Closed
jayconrod opened this issue Dec 11, 2017 · 0 comments
Closed

Make importpath optional for go_binary and go_test #1125

jayconrod opened this issue Dec 11, 2017 · 0 comments

Comments

@jayconrod
Copy link
Contributor

All Go rules have an importpath attribute, which is specified explicitly with the importpath attribute or is derived from go_prefix. importpath is used to determine output paths and is used by the experimental go_path rule.

We'd like to deprecate go_prefix (#721). In repositories without go_prefix, importpath is effectively mandatory, which is surprising for go_binary and go_test, since they can't be imported. When importpath isn't specified explicitly for these, we should create a dummy path. We should also report an error when rules without a real importpath are used in go_path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant