Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rules_go tests failing with Bazel@HEAD #3293

Closed
meteorcloudy opened this issue Sep 14, 2022 · 3 comments · Fixed by #3294
Closed

rules_go tests failing with Bazel@HEAD #3293

meteorcloudy opened this issue Sep 14, 2022 · 3 comments · Fixed by #3294

Comments

@meteorcloudy
Copy link
Contributor

meteorcloudy commented Sep 14, 2022

First reported at bazelbuild/continuous-integration#1429
https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/2632#01833a2a-4026-47c4-9730-89252449e823

    --- FAIL: TestLcovCoverage/without-race (5.06s)
        lcov_coverage_test.go:171: bazel-testlogs/src/lib_test/coverage.dat: does not contain:
            
            SF:src/other_lib.go
            FNF:0
            FNH:0
            DA:3,1
            DA:4,1
            DA:5,0
            DA:6,0
            DA:7,1
            LH:3
            LF:5
            end_of_record
            
            actual content:
            

//tests/core/coverage:lcov_coverage_test and //tests/core/coverage:lcov_test_main_coverage_test are broken by coverage_output_generator v2.6 introduced at bazelbuild/bazel@a70d84b

(There is another test //tests/core/cross:non_executable_test also failing, but due a Bazel issue, we are investigating)

@meteorcloudy
Copy link
Contributor Author

/cc @c-mita @fmeum

@fmeum
Copy link
Member

fmeum commented Sep 14, 2022

This one is on us: We have been lazy about populating InstrumentedFilesInfo since it wasn't necessary until v2.6. Will fix that and look into //tests/core/cross:non_executable_test as well.

@meteorcloudy
Copy link
Contributor Author

Thanks!
For //tests/core/cross:non_executable_test, we have figured it out, please check bazelbuild/continuous-integration#1429 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants