Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework gopackagedriver to use driver protocol from x/tools #3962

Open
sluongng opened this issue Jun 17, 2024 · 1 comment · May be fixed by #4185
Open

Rework gopackagedriver to use driver protocol from x/tools #3962

sluongng opened this issue Jun 17, 2024 · 1 comment · May be fixed by #4185

Comments

@sluongng
Copy link
Contributor

There is now an official documentation for the Package driver protocol via x/tools https://pkg.go.dev/golang.org/x/tools/go/packages#hdr-The_driver_protocol

This is what gopls will be built upon, and we should consider migrating there to have better compatibility with gopls in the future.

Worth noting that our package driver could now be used to power tools other than gopls. This includes golangci-lint or other linters in the same category. In the future, we should also aim to support official Go tools such as govulncheck via a proper package driver.

@ellie-idb
Copy link

I've made this change in our internal fork of gopackagesdriver. Currently waiting on approval to open-source it and contribute it back :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants