-
-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a more recent rules_android #1185
base: master
Are you sure you want to change the base?
Conversation
Necessary to avoid loading the `@bazel_tools//tools/android` package, which relies on bind()s to work, which rules_android HEAD has deleted.
@ted-xie I see this isn't ready for review yet, but it'd be nice to do the update :) Thank you for picking this up! |
@shs96c My pleasure. There's some kind of issue with bzlmod registries not understanding the fake 0.2.0 version I added in this PR (work on my machine and in other projects...) so that will require a little more investigation. |
We should probably just wait until |
Ah, here's part of the complication: this PR is actually a minor blocker for the next rules_android release, since it fixes broken toolchain issues with
I was not aware of this bzlmod behavior. So any git_override() in a library project essentially gets ignored by the root project? |
Would it be possible to override |
We're striving for compatibility Bazel 7.2.1 for the next rules_android release. We're already on 6.1 (link).
To clarify, I'm trying to fix a fundamental toolchain issue that will be exposed in rules_android @ HEAD; IOW, a bunch of BazelCI tests will fail without this fix eventually. We can do a single_version_override for rules_jvm_external, but according to the docs, that also only takes effect in the root module. To clarify even further: at rules_android HEAD, I've landed a bunch of commits removing (transitive) references to legacy
One possible solution to this is that on my side, we can release rules_android v0.5 first with a suggestion to users to apply a single_version_override patch with the |
Necessary to avoid loading the
@bazel_tools//tools/android
package, which relies on bind()s to work, which rules_android HEAD has deleted.