Add tests for pom generation #1208
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinnybod
requested review from
jin,
Wyverald,
shs96c and
cheister
as code owners
|
I am seeing that this is failing the bom generation tests. WIll take a look. |
shs96c
requested changes
Aug 27, 2024
vinnybod
commented
Sep 17, 2024
vinnybod
commented
Sep 17, 2024
|
It looks like the test failures are genuine. |
vinnybod
commented
Sep 17, 2024
shs96c
requested changes
Sep 18, 2024
vinnybod
changed the title
|
@shs96c It looks like #1279 fixes my original complaint 😄 :
I merged master into this branch and now all it does is add some new tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds tests for various pom generation scenarios.
Original context:
This fixes #1154
It seems like a bug that scope was being considered in the maven coordinates. I couldn't find any examples of that being the case. But it is common for
group:artifact:type:classifier:version.Demo of the issue: vinnybod/bazel_java_example@classifier-pom
Because bom generation was the only thing depending on sending the scope as part of the GAV, I refactored
maven_utils.generate_pomsoversioned_dep_coordinatesandunversioned_dep_coordinatesare expected to already beunpackedand_maven_dependencies_bomsets the type/scope itself. I also added tests.