Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump protobuf to 29.0 #1277

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

jin
Copy link
Collaborator

@jin jin commented Nov 5, 2024

No description provided.

@jin jin marked this pull request as ready for review November 5, 2024 05:34
@jin jin requested review from shs96c and cheister as code owners November 5, 2024 05:34
@jin jin enabled auto-merge (squash) November 5, 2024 05:35
# https://github.com/protocolbuffers/protobuf/commit/a80daa2a2caaaac9ebe9ae6bb1b639c2771c5c55
# This should be ok because we only use the protobuf dep to pull in the google/protobuf/wrappers.proto for testing
version = "27.2",
version = "29.0-rc2",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to update the version in repositories.bzl

@daniel-b2c2
Copy link

Please don't merge this, there is so much dependency cruft with this upgrade that needs explaining on their side, Mockito, Picolocli, OSGi tooling (not OSGi compatibility itself). Do a bazel REPIN and see the following:

DEBUG: /private/var/tmp/_bazel_dan/4062fc18797f0c796822bf92f1458040/external/rules_jvm_external~/private/rules/coursier.bzl:752:18: Found duplicate artifact versions
    com.google.guava:guava has multiple versions 33.3.1-jre, 32.0.1-jre
    org.mockito:mockito-core has multiple versions 5.14.2, 4.3.1
    info.picocli:picocli has multiple versions 4.7.6, 4.6.3

so many other libraries regressed to old versions

I'm not 100% certain but this: biz.aQute.bnd:biz.aQute.bnd.util is osgi buildtime cruft that's made it's way onto the runtime dependency list. Stuff that you use to create osgi dependencies but itself isn't required on the classpath, I could be wrong.

For sure: what on earth is mockito-core doing on a prod classpath.

Polite grumble opened here: protocolbuffers/protobuf#19451

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants