Extra maven artifacts support for java_export rule #805
Conversation
|
@cheister I have made one more commit towards templating maven coordinates. Could you please check? |
krisnaru
changed the title
examples/java-export/src/main/java/com/github/bazelbuild/rulesjvmexternal/example/export/BUILD
Outdated
Show resolved
Hide resolved
private/tools/java/rules/jvm/external/maven/MavenPublisher.java
Outdated
Show resolved
Hide resolved
private/tools/java/rules/jvm/external/maven/MavenPublisher.java
Outdated
Show resolved
Hide resolved
private/tools/java/rules/jvm/external/maven/MavenPublisher.java
Outdated
Show resolved
Hide resolved
krisnaru
force-pushed
the
master
branch
2 times, most recently
from
6620973 to
006f6ff
Compare
krisnaru
force-pushed
the
master
branch
2 times, most recently
from
f2c9503 to
f7bb009
Compare
|
@cheister could you please review and approve if you are fine with changes |
|
@cheister could you please review and approve if you are fine with changes |
private/tools/java/rules/jvm/external/maven/MavenPublisher.java
Outdated
Show resolved
Hide resolved
…ish any generic artifact like tar"
| @@ -106,6 +111,17 @@ public static void main(String[] args) | |||
| futures.add(upload(repo, credentials, coords, "-javadoc.jar", docJar, gpgSign)); | |||
| } | |||
|
|
|||
| if(args.length > 9) { | |||
| String ext = com.google.common.io.Files.getFileExtension(args[9]); | |||
There was a problem hiding this comment.
Won't this value need to be calculated per tuple, rather than just on the final one? eg war=foo.jar,tar=foo.tar would result in ext being set to tar for both the war and tar classifiers.
| for(String artifactTuple: extraArtifactTuples) { | ||
| String[] splits = artifactTuple.split("="); | ||
| String classifier = splits[0]; | ||
| Path artifact = getPathIfSet(splits[1]); |
There was a problem hiding this comment.
The Path should exist. If it doesn't, we've got real problems.... Paths.get is fine here.
|
@krisnaru, can I help you in any way to get this one over the line? It'd be lovely to have this in the tree.... |
|
I have continued the work in this PR in #926 . |
|
Is there any intention/support for extra classifier artifacts being in the BOM too? Would be useful for things like test-jars that sometime get published and depended on. |
@cjohnstoniv We didn't need that for our use team's use case, but I'm sure it would make sense to extend this to the BOM if you want to contribute a PR. |
Issue:
Java_export needs to upload multiple artifacts as part of single rule. Artifacts could be war/tar files and it needs to support classifier.
Example:
BUILD:
java_export(
name = "example-export",
extra_artifacts = {
"release": "//src/main/java/com/github/bazelbuild/rulesjvmexternal/example/export:tar",
},
maven_coordinates = "com.example:bazel-example:0.0.1",
runtime_deps = [
"//src/main/java/com/github/bazelbuild/rulesjvmexternal/example/export",
],
)
bazel run -define "maven_repo=file://$HOME/.m2/repository" :example-export.publish