Add support for snapshotted Maven artifacts #974
+86
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmmv
force-pushed
the
issue-901-snapshots
branch
from
8c5a468 to
080a5f7
Compare
|
Note that the conflict in the prebuilt tool is expected, because this PR is based off 5.3 and not main. I don't think you'll want to trust the artifact I built anyway, so I can remove it from the PR when the rest of it is reviewed. |
Artifacts with snapshots follow a different naming scheme than non-snapshoted ones. For snapshotted artifacts, the version component in the URL is the generic *-SNAPSHOT name, whereas the version component in the file name is the specific version number. Fixes bazel-contrib#901.
jmmv
force-pushed
the
issue-901-snapshots
branch
from
080a5f7 to
db0aeb8
Compare
|
Hi folks, any update on this? |
|
Facing same issue with 6.0, any chance this change will get into 6.1? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Artifacts with snapshots follow a different naming scheme than non-snapshoted ones. For snapshotted artifacts, the version component in the URL is the generic *-SNAPSHOT name, whereas the version component in the file name is the specific version number.
Fixes #901.