Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rules_* modules broken with Bazel 8.0.0rc8 #3260

Open
meteorcloudy opened this issue Nov 26, 2024 · 13 comments
Open

rules_* modules broken with Bazel 8.0.0rc8 #3260

meteorcloudy opened this issue Nov 26, 2024 · 13 comments

Comments

@meteorcloudy
Copy link
Member

meteorcloudy commented Nov 26, 2024 •
edited
Loading

The following modules are broken with [email protected] (Updated Dec 9):

BCR Bazel Compatibility Test: https://buildkite.com/bazel/bcr-bazel-compatibility-test/builds/103

[email protected]

Maintainers: @ted-xie, @ahumesky

[email protected]

Maintainers: @bazelbuild/bcr-maintainers

[email protected]

Maintainers: @lalten

[email protected]

Maintainers: @keith

[email protected]

Maintainers: @srikrsna-buf

[email protected]

Maintainers: @matts1

[email protected]

Maintainers: @kczulko

[email protected]

Maintainers: @pjk25

[email protected]

Maintainers: @sgammon

[email protected]

Maintainers: @avdv, @aherrmann

[email protected]

Maintainers: @luispadron

[email protected]

Maintainers: @EdSchouten

[email protected]

Maintainers: @Bencodes, @restingbull, @nkoroste

[email protected]

Maintainers: @benradf, @aherrmann

[email protected]

Maintainers: @alexeagle, @thesayyn

[email protected]

Maintainers: @opicaud

[email protected]

Maintainers: @oxidase

[email protected]

Maintainers: @aaliddell

[email protected]

Maintainers: @jvolkman

[email protected]

Maintainers: @avdv, @aherrmann

[email protected]

Maintainers: @jmmv

[email protected]

Maintainers: @cgrindel

[email protected]

Maintainers: @chickenandpork

[email protected]

Maintainers: @aherrmann
lalten added a commit to lalten/rules_appimage that referenced this issue Nov 26, 2024
@lalten
Upgrade with_cfg.bzl
61cc1a4 
Upgrade to https://github.com/fmeum/with_cfg.bzl/releases/tag/v0.6.0 to fix `Error: 'struct' value has no field or method 'AppleDebugOutputs'` and work towards bazelbuild/bazel-central-registry#3260
@lalten lalten mentioned this issue Nov 26, 2024
Merged
@nya3jp nya3jp mentioned this issue Nov 26, 2024
Closed
@yuyawk yuyawk mentioned this issue Nov 26, 2024
Merged
yuyawk added a commit to yuyawk/rules_build_error that referenced this issue Nov 26, 2024
@yuyawk
Support Bazel 8.0.0rc4 (#87)
3c0070f 
Addressing
bazelbuild/bazel-central-registry#3260
@nya3jp
Copy link
Contributor

nya3jp commented Nov 26, 2024

FYI: rules_contest has been fixed - the failure was due to the flag flip of --incompatible_disallow_empty_glob.

@yuyawk yuyawk mentioned this issue Nov 26, 2024
Merged
lalten added a commit to lalten/rules_appimage that referenced this issue Nov 26, 2024
@lalten
Upgrade with_cfg.bzl (#262)
c6434f0 
Upgrade `with_cfg.bzl` to
https://github.com/fmeum/with_cfg.bzl/releases/tag/v0.6.0 to fix `Error:
'struct' value has no field or method 'AppleDebugOutputs'` in
https://buildkite.com/bazel/bcr-bazel-compatibility-test/builds/72#019367bc-a37c-4ae9-acf2-4a0ccdfdf8c9
and work towards
bazelbuild/bazel-central-registry#3260
p0deje added a commit to bazel-contrib/rules_ruby that referenced this issue Nov 26, 2024
@p0deje
test: update for bazel 8.0.0rc4
ac57886 
This should unblock bazelbuild/bazel-central-registry#3260
p0deje added a commit to bazel-contrib/rules_ruby that referenced this issue Nov 26, 2024
@p0deje
test: update for bazel 8.0.0rc4
1b5df4a 
This should unblock bazelbuild/bazel-central-registry#3260
p0deje added a commit to bazel-contrib/rules_ruby that referenced this issue Nov 26, 2024
@p0deje
test: update for bazel 8.0.0rc4
7fc0743 
This should unblock bazelbuild/bazel-central-registry#3260
@p0deje p0deje mentioned this issue Nov 26, 2024
Merged
@p0deje
Copy link

p0deje commented Nov 26, 2024

rules_ruby are fixed in 0.14.1, the issue was usage of --incompatible_remote_results_ignore_disk in tests.

@ouillie
Copy link

ouillie commented Nov 26, 2024 •
edited
Loading

rules_wasm fixed: #3268.

Filed bazelbuild/bazel#24499 to discuss a better solution, but was able to just duplicate some data as a workaround. The breaking change stems from bazelbuild/bazel@27487cf which causes the patch tool for http_archive to always receive a -p option, even when patch_args is empty. Is that an issue for anybody else? Or was that just because of my abuse of patch_tool.

@fmeum
Copy link
Contributor

fmeum commented Nov 27, 2024

[email protected] contains a fix.

@ouillie Can you use patch_cmds instead? That's the recommended way to run arbitrary commands.

@mattyclarkson mattyclarkson mentioned this issue Nov 27, 2024
Merged
fmeum pushed a commit that referenced this issue Nov 27, 2024
@mattyclarkson
Bazel 8 compatibility for `rules_{gzip,bzip2,xz,zstd,curl,squashfs,di…
db1f139 
…ff}`, `ape` and `download_utils` (#3270)

Upstream modules now have multiple Bazel version testing in the CI now.

#3260
@meteorcloudy meteorcloudy mentioned this issue Nov 28, 2024
Merged
@EdSchouten
Copy link
Contributor

[email protected]

Maintainers: @EdSchouten

It looks like all of these breakages are caused by jsonnet, not rules_jsonnet. Unfortunately, I am not able to make able to make contributions to that repository directly. Sorry!

Once these build failures are addressed on the jsonnet side, I'd be more than happy to cut a new release of rules_jsonnet that depends on it.

@meteorcloudy
Copy link
Member Author

@EdSchouten Yes, jsonnet is also identified in #3056
@mortenmj Can you help fixing this since you contributed the initial BCR module.

@avdv
Copy link
Contributor

avdv commented Nov 28, 2024

rules_sh, rules_nixpkgs and rules_haskell all fail with the same error:

	File "/var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/2bbac50a5364a2d14c5e3065383ed7e2/external/rules_sh+/sh/posix.bzl", line 11, column 55, in <toplevel>
		load("@bazel_tools//tools/cpp:lib_cc_configure.bzl", "get_cpu_value")
Error: file '@bazel_tools//tools/cpp:lib_cc_configure.bzl' does not contain symbol 'get_cpu_value'

We were relying on this macro, but apparently it has been removed and the one in rules_cc is private. We are going to vendor a copy of this macro into our rules to solve this, but maybe others are also having this issue and copying this code around seems not very maintainable. WDYT?

meteorcloudy added a commit to bazelbuild/rules_cc that referenced this issue Nov 28, 2024
@meteorcloudy
Expose get_cpu_value in toolchain_config_utils.bzl
8d7f986 
Addressing bazelbuild/bazel-central-registry#3260 (comment)
@meteorcloudy meteorcloudy mentioned this issue Nov 28, 2024
Closed
@meteorcloudy
Copy link
Member Author

@avdv I think we could expose this in https://github.com/bazelbuild/rules_cc/blob/8395ec0172270f3bf92cd7b06c9b5b3f1f679e88/cc/toolchains/toolchain_config_utils.bzl#L22

Sent bazelbuild/rules_cc#283

copybara-service bot pushed a commit to bazelbuild/rules_cc that referenced this issue Nov 28, 2024
@meteorcloudy @copybara-github
Expose get_cpu_value in toolchain_config_utils.bzl
5be90a4 
Copybara Import from #283

BEGIN_PUBLIC
Expose get_cpu_value in toolchain_config_utils.bzl (#283)

Addressing bazelbuild/bazel-central-registry#3260 (comment)

Closes #283
END_PUBLIC

COPYBARA_INTEGRATE_REVIEW=#283 from bazelbuild:meteorcloudy-patch-5 8d7f986
PiperOrigin-RevId: 700977422
Change-Id: I979446d5d79d8da465ec538632326d6d2c6932f7
@jmillikin
Copy link
Contributor

rules_flex fix: #3285

@chickenandpork
Copy link
Contributor

rules_Synology will take a few days to fix: I butchered the bcr template and I’m afk 3 days. I can’t reproduce the failure but have a fix for a guess of the cause into v0.0.3

aherrmann added a commit to aherrmann/rules_zig that referenced this issue Nov 30, 2024
@aherrmann
Remove remote_results_ignore_disk for Bazel 8 compat
89105cb 
See:
- bazelbuild/bazel-central-registry#3260
- https://buildkite.com/bazel/bcr-bazel-compatibility-test/builds/72#019367e3-d4a4-4d84-8549-45a01c2fd51c/200-210
@aherrmann aherrmann mentioned this issue Nov 30, 2024
Merged
@abrisco abrisco mentioned this issue Dec 2, 2024
Closed
@chickenandpork
Copy link
Contributor

rules_Synology will take a few days to fix: I butchered the bcr template and I’m afk 3 days. I can’t reproduce the failure but have a fix for a guess of the cause into v0.0.3

After some templating issues, #3330 brings in v0.1.1 (via chickenandpork/rules_synology#176) which might have a fix for rules_synology -- unfortunately, I cannot repro, so I'm guessing based on the error message.

@keith
Copy link
Member

keith commented Dec 5, 2024

@meteorcloudy can we pass --check_direct_dependencies=off in this CI job? in my case it's a bcr module where that as an error is checked in to the .bazelrc, so it's a false positive https://buildkite.com/bazel/bcr-bazel-compatibility-test/builds/72#019367c7-9404-453f-9c57-66b13aca10d9

@meteorcloudy meteorcloudy mentioned this issue Dec 6, 2024
Merged
@chickenandpork chickenandpork mentioned this issue Dec 7, 2024
Merged
meteorcloudy added a commit to bazelbuild/continuous-integration that referenced this issue Dec 9, 2024
@meteorcloudy
bcr_presubmit: pass --check_direct_dependencies=off for test module i…
99bea4e 
…f bazel version is overridden (#2140)

Address:
bazelbuild/bazel-central-registry#3260 (comment)
@meteorcloudy meteorcloudy changed the title rules_* modules broken with Bazel 8.0.0rc4 rules_* modules broken with Bazel 8.0.0rc8 Dec 9, 2024
@meteorcloudy
Copy link
Member Author

@keith --check_direct_dependencies is now set to warning when the Bazel version is changed, the new error from rules_apple_linker suggests rules_apple might need to be updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
10 participants
@nya3jp @keith @jmillikin @p0deje @EdSchouten @chickenandpork @avdv @meteorcloudy @fmeum @ouillie