Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify universal-robots-client-library build to export more files #3390

Merged
merged 3 commits into from
Dec 11, 2024
Merged

Modify universal-robots-client-library build to export more files #3390

merged 3 commits into from
Dec 11, 2024
+473 −1

Conversation

FilipposSot
Copy link
Contributor

No description provided.

@bazel-io
Copy link
Member

Hello @b-bremer, modules you maintain (universal-robots-client-library) have been updated in this PR. Please review the changes.

@FilipposSot
Copy link
Contributor Author

@bazel-io skip_check unstable_url

@bazel-io bazel-io added the skip-url-stability-check Skip the URL stability check for the PR label Dec 11, 2024
b-bremer
b-bremer previously approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@b-bremer b-bremer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only change is adding

+    "examples/resources/rtde_input_recipe.txt",
+    "examples/resources/rtde_output_recipe.txt",
+    "resources/external_control.urscript",

to the exports_files rule

bazel-io
bazel-io previously approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@bazel-io bazel-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @bazelbuild/bcr-maintainers, all modules in this PR have been approved by their maintainers. Please take a final look to merge this PR.

@bazel-io bazel-io dismissed stale reviews from b-bremer and themself December 11, 2024 10:53

Require module maintainers' approval for newly pushed changes.

bazel-io
bazel-io approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@bazel-io bazel-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @bazelbuild/bcr-maintainers, all modules in this PR have been approved by their maintainers. Please take a final look to merge this PR.

@meteorcloudy meteorcloudy merged commit 5abe474 into bazelbuild:main Dec 11, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bazel-io bazel-io bazel-io approved these changes

@b-bremer b-bremer b-bremer approved these changes

Assignees
No one assigned
Labels
skip-url-stability-check Skip the URL stability check for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@FilipposSot @bazel-io @b-bremer @meteorcloudy