Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bazel 8 compatibility for rules_{gzip,bzip2,xz,zstd,curl,squashfs,diff}, ape and download_utils #3270

Merged
merged 10 commits into from
Nov 27, 2024

Conversation

mattyclarkson
Copy link
Contributor

@mattyclarkson mattyclarkson commented Nov 27, 2024

Upstream modules now have multiple Bazel version testing in the CI now.

#3260

@fmeum fmeum added the presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval label Nov 27, 2024
fmeum
fmeum previously approved these changes Nov 27, 2024
@fmeum fmeum enabled auto-merge (squash) November 27, 2024 13:53
@mattyclarkson mattyclarkson marked this pull request as draft November 27, 2024 14:22
auto-merge was automatically disabled November 27, 2024 14:22

Pull request was converted to draft

@mattyclarkson
Copy link
Contributor Author

We don't have Mac/Windows coverage upstream...yet. The team is working on getting them sorted.

I'll work through the regressions for ape/rules_curl regressions.

@bazel-io bazel-io dismissed fmeum’s stale review November 27, 2024 14:30

Require module maintainers' approval for newly pushed changes.

@mattyclarkson
Copy link
Contributor Author

I accidentally enabled Windows coverage for rules_curl which isn't supported yet.

ape has a regression in it's tests for Apple silicon that does not affect the downstream usage of the module, hence the packages that use ape passing. I can create a follow-up PR that resolves the regression in the tests on MacOS.

rules_curl has a regression on Apple Silicon. It is currently in alpha and MacOS support was a best effort. I feel having working Bazel 8 on the supported Linux is better than waiting for a fixed release.

Our team is working on getting CI runners for Mac/Windows. Once we have those, we can avoid these issues in the future and I can start moving the modules to stable releases.

@mattyclarkson mattyclarkson marked this pull request as ready for review November 27, 2024 14:41
@mattyclarkson
Copy link
Contributor Author

There are two (what look like) infrastructure failures:

  | 2024/11/27 14:42:34 Downloading https://releases.bazel.build/8.0.0/rc4/bazel-8.0.0rc4-linux-x86_64...
  | 2024/11/27 14:42:36 could not download Bazel: failed to download bazel: failed to download bazel: could not copy from https://releases.bazel.build/8.0.0/rc4/bazel-8.0.0rc4-linux-x86_64 to /var/lib/buildkite-agent/.cache/bazelisk/downloads/_tmp/download3159232164: stream error: stream ID 1; INTERNAL_ERROR; received from peer
  | Command '['bazel', 'info', 'output_base']' returned non-zero exit status 1.
  | 🚨 Error: The command exited with status 1
  | user command error: The plugin docker command hook exited with status 1

@fmeum fmeum enabled auto-merge (squash) November 27, 2024 20:10
@fmeum fmeum merged commit db1f139 into bazelbuild:main Nov 27, 2024
123 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants