Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile: critical paths should include target label #24580

Open
sluongng opened this issue Dec 5, 2024 · 0 comments · May be fixed by #24588
Open

Profile: critical paths should include target label #24580

sluongng opened this issue Dec 5, 2024 · 0 comments · May be fixed by #24588
Labels
team-Performance Issues for Performance teams type: feature request

Comments

@sluongng
Copy link
Contributor

sluongng commented Dec 5, 2024

Description of the feature request:

These flags have been very helpful in correlating the profile data with actual build target and actions

--[no]experimental_profile_include_primary_output default: "false"
Includes the extra "out" attribute in action events that contains the exec path to the action's primary output.
Tags: bazel_monitoring

--[no]experimental_profile_include_target_configuration default: "false"
Includes target configuration hash in action events' JSON profile data.
Tags: bazel_monitoring

--[no]experimental_profile_include_target_label default: "false"
Includes target label in action events' JSON profile data.
Tags: bazel_monitoring

But currently, the Critical Path spans are not decorated with the same information.
It would be nice to get this information added to the critical path spans as well.

Which category does this issue belong to?

Performance

What underlying problem are you trying to solve with this feature?

Improve profile information

Which operating system are you running Bazel on?

No response

What is the output of bazel info release?

No response

If bazel info release returns development version or (@non-git), tell us how you built Bazel.

No response

What's the output of git remote get-url origin; git rev-parse HEAD ?

No response

Have you found anything relevant by searching the web?

No response

Any other information, logs, or outputs that you want to share?

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Performance Issues for Performance teams type: feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants