Move Bash and Python runfiles libraries out of Bazel

[fmeum]

The Bash and Python runfiles libraries in @bazel_tools are replaced with aliases to @rules_<lang>//<lang>/runfiles.

This requires skipping load visibility checks for resolved WORKSPACE files, which are going away anyway.

[fmeum]

FYI @comius, let me know if you want to merge this as is (Bash + Python).

[comius]

FYI @comius, let me know if you want to merge this as is (Bash + Python).

It looks ok to me.

[fmeum]

@comius I updated the description, feel free to merge this. I will open a new PR for Java and C++.

[fmeum]

@bazel-io fork 8.0.0

[iancha1992]

@fmeum Can you please resolve the conflicts? Thanks!

[fmeum]

@iancha1992 Done!

[iancha1992]

@fmeum Looks like one of the tests is failing

[fmeum]

@iancha1992 Looks like CI has trouble connecting to github.com.

[fmeum]

@iancha1992 I sent #24425 to fix this, I guess that the failing tests just aren't supposed to hit anything other than the mirror.

[fmeum]

@Wyverald Both https://storage.googleapis.com/bazel-untrusted-buildkite-artifacts/01934dca-8eef-4338-b6e7-d88f65fd1281/src/test/shell/bazel/workspace_test/shard_1_of_5/test_attempts/attempt_1.log and https://storage.googleapis.com/bazel-untrusted-buildkite-artifacts/01934dca-8eef-4338-b6e7-d88f65fd1281/src/test/shell/bazel/workspace_test/shard_5_of_5/test_attempts/attempt_1.log have server crashes triggered by download failures.

[fmeum]

@meteorcloudy The remaining failure is due to --experimental_repository_resolved_file not working when a resolved repo rule has limited load visibility. Since this functionality is WORKSPACE only, should I fix it?

[meteorcloudy]

Since this functionality is WORKSPACE only, should I fix it?

I don't think so, can we work around this in the test? This feature will just go way when we delete WORKSPACE.

[fmeum]

@meteorcloudy I fixed the root cause, it just took one line.

[fmeum]

@bazel-io flag

[fmeum]

(for 8.1.0)

[iancha1992]

@bazel-io fork 8.0.0

[alexeagle]

@iancha1992 @fmeum I just noticed maybe a mistake here, Fabian intended it for 8.1.0 but it was flagged for 8.0.0?

[iancha1992]

@alexeagle We'll move it to 8.1.0 milestone if it doesn't make it in time.

[meteorcloudy]

@fmeum Is this change actually backwards-compatible? Wouldn't users need to update the runfiles boilerplate like?
https://cs.opensource.google/bazel/bazel/+/master:src/test/shell/integration/bazel_query_test.sh;l=23-34

[fmeum]

@fmeum Is this change actually backwards-compatible? Wouldn't users need to update the runfiles boilerplate like?
https://cs.opensource.google/bazel/bazel/+/master:src/test/shell/integration/bazel_query_test.sh;l=23-34

It is meant to be backwards compatible, due to some trickery with root symlinks: https://github.com/bazelbuild/rules_shell/blob/104505faea10e1fe50bb7f7a5b3142b63181e644/shell/runfiles/BUILD#L19

[meteorcloudy]

I see, we were having some trouble importing this change, I guess internal we still have to keep a copy of runfiles.bash at the old location.

[fmeum]

I see, we were having some trouble importing this change, I guess internal we still have to keep a copy of runfiles.bash at the old location.

I suspect that's because your copybara rewrite for the runfiles path doesn't apply to the BUILD file line I linked. That should be the only place that needs changing.