Move Bash and Python runfiles libraries out of Bazel

MODULE.bazel

@@ -34,7 +34,7 @@ bazel_dep(name = "rules_testing", version = "0.6.0")
 bazel_dep(name = "googletest", version = "1.15.2", repo_name = "com_google_googletest")
 bazel_dep(name = "with_cfg.bzl", version = "0.6.0")
 bazel_dep(name = "abseil-cpp", version = "20240722.0")
-bazel_dep(name = "rules_shell", version = "0.2.0")
+bazel_dep(name = "rules_shell", version = "0.3.0")
 
 # TODO: wyv@ - use release 29.0 when that's out
 # repo_name needs to be used, until WORKSPACE mode is to be supported in bazel_tools

src/BUILD

@@ -650,6 +650,7 @@ filegroup(
         "@rules_license//:WORKSPACE",
         "@rules_pkg//:WORKSPACE",
         "@rules_python//:WORKSPACE",
+        "@rules_shell//shell:rules_bzl",
         "@rules_testing//:LICENSE",
     ] + select({
         "//src/conditions:linux_x86_64": ["@remotejdk%s_linux//:WORKSPACE" % v for v in JDK_VERSIONS],

src/MODULE.tools

@@ -42,6 +42,6 @@ bazel_dep(name = "protobuf", version = "29.0-rc3", repo_name = "com_google_proto
 bazel_dep(name = "rules_java", version = "8.5.0")
 bazel_dep(name = "rules_cc", version = "0.0.16")
 bazel_dep(name = "rules_python", version = "0.40.0")
-bazel_dep(name = "rules_shell", version = "0.2.0")
+bazel_dep(name = "rules_shell", version = "0.3.0")
 # add rules_android
 # add apple_support

src/main/java/com/google/devtools/build/lib/bazel/rules/BUILD

@@ -138,6 +138,9 @@ gen_workspace_stanza(
         protobuf_deps()
         load("@rules_java//java:repositories.bzl", "rules_java_toolchains")
         rules_java_toolchains()
+        load("@rules_shell//shell:repositories.bzl", "rules_shell_dependencies", "rules_shell_toolchains")
+        rules_shell_dependencies()
+        rules_shell_toolchains()
     """,
     preamble = """
         load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
@@ -150,6 +153,7 @@ gen_workspace_stanza(
         "rules_cc",  # For auto-load cc rules symbols
         "rules_python",  # For auto-load python rules symbols
         "rules_license",  # for license attestations
+        "rules_shell",  # For auto-load of shell rules symbols
     ],
     use_maybe = 1,
     visibility = ["//:__pkg__"],

src/main/java/com/google/devtools/build/lib/skyframe/WorkspaceFileFunction.java

@@ -360,7 +360,7 @@ public SkyValue compute(SkyKey skyKey, Environment env)
               keys.build(),
               starlarkSemantics,
               bzlLoadFunctionForInlining,
-              /* checkVisibility= */ true,
+              /* checkVisibility= */ !useWorkspaceResolvedFile,
               BazelSkyframeExecutorConstants.ACTION_ON_FILESYSTEM_ERROR_CODE_LOADING_BZL_FILE);
     } catch (NoSuchPackageException e) {
       throw new WorkspaceFileFunctionException(e, Transience.PERSISTENT);

tools/bash/runfiles/BUILD

@@ -1,6 +1,3 @@
-load("@rules_shell//shell:sh_library.bzl", "sh_library")
-load("@rules_shell//shell:sh_test.bzl", "sh_test")
-
 package(default_visibility = ["//visibility:private"])
 
 filegroup(
@@ -19,19 +16,6 @@ filegroup(
     name = "embedded_tools",
     srcs = [
         "BUILD.tools",
-        "runfiles.bash",
     ],
     visibility = ["//tools/bash:__pkg__"],
 )
-
-sh_library(
-    name = "runfiles_lib",
-    testonly = 1,
-    srcs = ["runfiles.bash"],
-)
-
-sh_test(
-    name = "runfiles_test",
-    srcs = ["runfiles_test.bash"],
-    deps = [":runfiles_lib"],
-)

tools/bash/runfiles/BUILD.tools

@@ -1,7 +1,5 @@
-load("@rules_shell//shell:sh_library.bzl", "sh_library")
-
-sh_library(
+alias(
     name = "runfiles",
-    srcs = ["runfiles.bash"],
+    actual = "@rules_shell//shell/runfiles",
     visibility = ["//visibility:public"],
 )