Fix builtins_bzl_zip build when io_bazel is not the root module #24330
+5
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building bazel as a non root module the path needed by zip_builtins is external/<repo>/src/main/starlark/builtins_bzl instead of src/main/starlark/builtins_bzl. This patch gives the zip_builtins script the dirname of the package build file and uses $location to resolve correct path. Signed-off-by: Torgil Svensson <[email protected]>
github-actions
bot
added
the
awaiting-review
iancha1992
added
the
team-Starlark-Interpreter
|
@iancha1992 where is this PR in the queue? The patch looks "fairly trivial" to me, I'm curios if there is any pitfalls here to watch out for. |
|
@quic-torgil this PR needs to be reviewed before it gets merged. Let me see if someone can respond. Thank you for being patient! |
|
The patch looks good, but can you elaborate why you need to build builtins_bzl_zip build when bazel is not the root module? In general, the bazel repo is not supposed to be used as a dependency. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building bazel as a non root module the path needed by zip_builtins is external/%repo%/src/main/starlark/builtins_bzl instead of src/main/starlark/builtins_bzl.
This patch gives the zip_builtins script the dirname of the package build file and uses $location to resolve correct path.