Fix Unicode encoding issues in Bazel's use of Starlark #24417
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bazel internally uses
String
as a container for raw bytes assumed to be UTF-8, which differs from ordinary usage ofString
as a container for UTF-16 characters. This requires special implementations of certain Starlark functions that care about the notion of a "character":{l,r,}split
must not strip non-ASCII whitespace as those may be part of a UTF-8-encoded non-whitespace character.json.decode
has to emit UTF-8 bytes rather than UTF-16 characters.Compatibility is verified by running all script-based tests both parsed as UTF-8 and using Bazel's internal encoding.