Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete BaselineCoverageResult #24488

Closed
wants to merge 1 commit into from
Closed

Delete BaselineCoverageResult #24488

wants to merge 1 commit into from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Nov 26, 2024

This event predates BEP and hinders Starlarkification of baseline coverage actions.

@fmeum
Delete BaselineCoverageResult
32bbf98 
This event predates BEP and hinders Starlarkification of baseline coverage actions.
@fmeum fmeum requested a review from a team as a code owner November 26, 2024 09:28
@fmeum fmeum requested review from katre and c-mita and removed request for a team and katre November 26, 2024 09:28
@github-actions github-actions bot added team-Configurability platforms, toolchains, cquery, select(), config transitions awaiting-review PR is awaiting review from an assigned reviewer labels Nov 26, 2024
c-mita
c-mita approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@c-mita c-mita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAICT this is only used in an internal class for a deprecated system (replaced by the BEP).

Baseline coverage is undeveloped so this should not be missed.

@c-mita c-mita added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally coverage and removed awaiting-review PR is awaiting review from an assigned reviewer labels Nov 26, 2024
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Nov 27, 2024
@fmeum fmeum deleted the drop-legacy-baseline-coverage-event branch November 27, 2024 18:51
@fmeum
Copy link
Collaborator Author

fmeum commented Dec 4, 2024

@bazel-io flag

@fmeum
Copy link
Collaborator Author

fmeum commented Dec 4, 2024

(for 8.1.0)

@bazel-io bazel-io added the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Dec 4, 2024
@iancha1992
Copy link
Member

@bazel-io fork 8.1.0

@bazel-io bazel-io removed the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Dec 10, 2024
@bazel-io bazel-io mentioned this pull request Dec 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c-mita c-mita c-mita approved these changes

Assignees
No one assigned
Labels
coverage team-Configurability platforms, toolchains, cquery, select(), config transitions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fmeum @iancha1992 @c-mita @bazel-io