Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid dict syntax in macro docs #24585

Closed
wants to merge 1 commit into from
Closed

Fix invalid dict syntax in macro docs #24585

wants to merge 1 commit into from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Dec 6, 2024

No description provided.

@fmeum fmeum requested a review from brandjon December 6, 2024 10:34
@github-actions github-actions bot added team-Documentation Documentation improvements that cannot be directly linked to other team labels awaiting-review PR is awaiting review from an assigned reviewer labels Dec 6, 2024
@fmeum
Copy link
Collaborator Author

fmeum commented Dec 6, 2024

@bazel-io flag

@bazel-io bazel-io added the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Dec 6, 2024
@brandjon brandjon self-assigned this Dec 9, 2024
@tetromino
Copy link
Contributor

Thanks!

@copybara-service copybara-service bot closed this in baa0159 Dec 9, 2024
@github-actions github-actions bot removed the awaiting-review PR is awaiting review from an assigned reviewer label Dec 9, 2024
@iancha1992
Copy link
Member

@bazel-io fork 8.1.0

@bazel-io bazel-io removed the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Dec 10, 2024
@bazel-io bazel-io mentioned this pull request Dec 10, 2024
Closed
@fmeum fmeum deleted the patch-11 branch December 11, 2024 10:49
@fmeum
Copy link
Collaborator Author

fmeum commented Dec 11, 2024

@bazel-io fork 8.0.1

@bazel-io bazel-io mentioned this pull request Dec 11, 2024
Closed
bazel-io pushed a commit to bazel-io/bazel that referenced this pull request Dec 11, 2024
@fmeum @bazel-io
Fix invalid dict syntax in macro docs
0037ee5 
Closes bazelbuild#24585.

PiperOrigin-RevId: 704366607
Change-Id: Ibdc89e1ad30ded6f3b69edc2877fcac78c622ea9
@bazel-io bazel-io mentioned this pull request Dec 11, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Dec 11, 2024
@bazel-io @fmeum
[8.0.1] Fix invalid dict syntax in macro docs (#24648)
193856b 
Closes #24585.

PiperOrigin-RevId: 704366607
Change-Id: Ibdc89e1ad30ded6f3b69edc2877fcac78c622ea9

Commit
baa0159

Co-authored-by: Fabian Meumertzheim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fweikert fweikert fweikert approved these changes

@gregestren gregestren Awaiting requested review from gregestren gregestren is a code owner

@brandjon brandjon Awaiting requested review from brandjon

Assignees

@brandjon brandjon

Labels
team-Documentation Documentation improvements that cannot be directly linked to other team labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@fmeum @tetromino @iancha1992 @fweikert @brandjon @bazel-io