Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update java_tools v13.14 / rules_java 8.7.0 #24604

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Update java_tools v13.14 / rules_java 8.7.0 #24604

wants to merge 3 commits into from

Conversation

iancha1992
Copy link
Member

@iancha1992 iancha1992 added team-Rules-Java Issues for Java rules awaiting-review PR is awaiting review from an assigned reviewer labels Dec 6, 2024
@iancha1992 iancha1992 requested a review from hvadehra December 6, 2024 23:09
@iancha1992 iancha1992 mentioned this pull request Dec 6, 2024
Open
@iancha1992 iancha1992 marked this pull request as ready for review December 6, 2024 23:29
@hvadehra
Copy link
Member

hvadehra commented Dec 9, 2024

LGTM, but do we want to restart the process to incorporate bazelbuild/rules_java#250 ?

@fmeum
Copy link
Collaborator

fmeum commented Dec 9, 2024

cd4580f has also landed now and would need to make it into a release of java_tools.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hvadehra hvadehra Awaiting requested review from hvadehra

Assignees
No one assigned
Labels
awaiting-review PR is awaiting review from an assigned reviewer team-Rules-Java Issues for Java rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iancha1992 @hvadehra @fmeum